Fix relative includes#19
Open
manisandro wants to merge 1 commit intowernerd:masterfrom
manisandro:includes
Open
Fix relative includes#19manisandro wants to merge 1 commit intowernerd:masterfrom manisandro:includes
manisandro wants to merge 1 commit intowernerd:masterfrom
manisandro:includes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installed libzrtpcpp headers (placed in
/usr/include/libzrtpcpp) usually include themselves viaand projects using libzrtpcpp do so as well (i.e. sflphone). There are however a few cases where headers in
/usr/include/libzrtpcppinclude other headers using the angle-bracket#includebut without thelibzrtpcpp/, i.e.This breaks compilation of i.e. sflphone, since the headers cannot be found. This pull request changes those include statements to using the
#includewith quotes:Using
#include <libzrtpcpp/XXX>in those cases does not work since in the source files the headers are not placed beneath thelibzrtpcppfolder.