1.10 Update #8
Open
1.10 Update #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 27, 2016 22:16
|
this PR has seen some shit over the years, can we get a merge bros? |
Owner
|
This is the first time I have seen this PR. It only took me 5 years sorry! |
|
@werty1124 dont worry, unmerged prs age like fine wine. at least thats what maintainers keep telling me |
|
we did it |
its not merged yet unfortunately it has to be reviewed |
Kylerace
reviewed
Apr 2, 2021
| else | ||
| { | ||
| playerIn.addChatMessage(new ChatComponentText("you can feel a strange presence")); | ||
| playerIn.addChatMessage(new TextComponentString("you can feel a strange presence")); |
There was a problem hiding this comment.
Suggested change
| playerIn.addChatMessage(new TextComponentString("you can feel a strange presence")); | |
| playerIn.addChatMessage(new TextComponentString("You can feel a strange presence.")); |
| if(!worldIn.isRemote) | ||
| { | ||
| playerIn.addChatMessage(new ChatComponentText("You feel weak after transfering energy to the crystal")); | ||
| playerIn.addChatMessage(new TextComponentString("You feel weak after transfering energy to the crystal")); |
There was a problem hiding this comment.
Suggested change
| playerIn.addChatMessage(new TextComponentString("You feel weak after transfering energy to the crystal")); | |
| playerIn.addChatMessage(new TextComponentString("You feel weak after transferring energy to the crystal.")); |
|
my work here is done 😎 |
|
Still not merged smh 😔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed quite a few bugs.