fix - handle byte encode error in set_auth_credentials function#157
Open
saurabhritu wants to merge 1 commit intowialon:masterfrom
Open
fix - handle byte encode error in set_auth_credentials function#157saurabhritu wants to merge 1 commit intowialon:masterfrom
saurabhritu wants to merge 1 commit intowialon:masterfrom
Conversation
…broker is initially unavailable. context - if the MQTT broker was down at when fast-api aap start and became available later, when the fast-mqtt client try to reconnect using fast_mqtt.mqtt_startup after on failed attempt, the function set_auth_credentials receive byte-encoded that caused encode errors due to no checks in the function.This commit adds handling to prevent crashes during such reconnect scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix - handle byte encode error in set_auth_credentials function when broker is initially unavailable.
context - if the MQTT broker was down at when fast-api aap start and became available later, when the fast-mqtt client try to reconnect using fast_mqtt.mqtt_startup after on failed attempt, the function set_
auth_credentials receive byte-encoded that caused encode errors due to no checks in the function.This commit adds handling to prevent crashes during such reconnect scenarios.