Skip to content

build: Add phan #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abijeet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: Add phan #465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php: [8.1, 8.2, 8.3, 8.4, 8.5]
# PHP v8.5 has issues with Phan 5.5.1
# Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead
php: [8.1, 8.2, 8.3, 8.4]
steps:
- name: Checkout
uses: actions/checkout@v2
Expand All @@ -28,3 +30,6 @@ jobs:

- name: Run tests
run: php ./vendor/bin/phpunit

- name: Running phan
run: composer run-script phan
2 changes: 2 additions & 0 deletions .phan/config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<?php
return require __DIR__ . '/../vendor/mediawiki/mediawiki-phan-config/src/config.php';
5 changes: 4 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"ext-curl": "*",
"phpunit/phpunit": "9.6.20",
"mediawiki/mediawiki-codesniffer": "48.0.0",
"mediawiki/mediawiki-phan-config": "0.17.0",
"mustangostang/spyc": "0.6.3",
"mhujer/yaml-sort-checker": "^1.5"
},
Expand All @@ -55,11 +56,13 @@
"fix": "phpcbf",
"cs": "phpcs -sp",
"yaml-sort-check": "yaml-sort-checker",
"phan": "phan -d . --long-progress-bar",
"test": [
"@composer validate --no-interaction",
"phpunit",
"@cs",
"@yaml-sort-check"
"@yaml-sort-check",
"@phan"
]
},
"config": {
Expand Down
Loading