Support for socks5 in pac file.#13
Open
edolphin-ydf wants to merge 2 commits intowilliambailey:masterfrom
Open
Support for socks5 in pac file.#13edolphin-ydf wants to merge 2 commits intowilliambailey:masterfrom
edolphin-ydf wants to merge 2 commits intowilliambailey:masterfrom
Conversation
Owner
|
Awesome. Thanks for the PR. Apologies it went so long without a reply. I'll try to find some time to have a deeper look at the code and the new dependencies and see if I get this into the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for make the tool. But it doesn't support a socks5 proxy in the pac file currently. I think a socks5 is very commonly for many users, such as the shadowsocks client export a socks5 server.
So I added this feature.
And I also added a cache in the OttoEngine, which make the
FindProxyForURLfaster.