Add option (-s) to explicitly specify the URL scheme#14
Open
0xced wants to merge 1 commit intowilliambailey:masterfrom
Open
Add option (-s) to explicitly specify the URL scheme#140xced wants to merge 1 commit intowilliambailey:masterfrom
0xced wants to merge 1 commit intowilliambailey:masterfrom
Conversation
Explicitly specifying the URL scheme might be required depending on how the PAC file is written. For example, if the script returns a different value based on the URL scheme then passing the full URL to the `FindProxyForURL` method might be required. Here's an example of such a (real life) PAC script: ```js if ((url.substring(0,5) != "http:") && (url.substring(0,6) != "https:")) return "DIRECT"; ``` Since the [request URL scheme is not known][1], passing it explicitly through a command line option solves this issue. The README has also been updated to reflect the intended usage of the new `-s` option. Please bear in mind that this is the first time I ever write some go code. 😇 [1]: golang/go#28940
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly specifying the URL scheme might be required depending on how the PAC file is written. For example, if the script returns a different value based on the URL scheme then passing the full URL to the
FindProxyForURLmethod might be required.Here's an example of such a (real life) PAC script:
Since the request URL scheme is not known, passing it explicitly through a command line option solves this issue.
The README has also been updated to reflect the intended usage of the new
-soption.Please bear in mind that this is the first time I ever write some go code. 😇