-
Notifications
You must be signed in to change notification settings - Fork 438
API draft for the rewrite #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
oskardotglobal
wants to merge
16
commits into
winapps-org:rewrite
Choose a base branch
from
oskardotglobal:feat-rewrite-api
base: rewrite
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2f312af
fix: squash history because of broken rebase
oskardotglobal bc9fc5d
feat: doc .envrc parameters & allow overriding toolchain
oskardotglobal 0740791
fix: typo in ci.yaml
oskardotglobal 81cfe22
feat: add markdown license
oskardotglobal a25980e
fix(ci): use compatible toolchain action
oskardotglobal badf5c0
Merge branch 'feat-rewrite-api' of github.com:oskardotglobal/winapps …
oskardotglobal 0f49aa9
feat: add setup
oskardotglobal 858f790
feat: pin foreign action SHA
oskardotglobal bc49e92
fix: drop quickemu subcommand
oskardotglobal a3781a7
fix: don't deadlock on setup
oskardotglobal 5e7cc1a
chore: address most coderabbit lints
oskardotglobal a33c5e3
chore: address more comments
oskardotglobal c0e6538
feat: upgrade packages & switch to 2024
oskardotglobal ad3634a
feat: simplify memory management
oskardotglobal 37de6c1
feat: import compose.yaml from main
oskardotglobal b0519a0
fix: properly support quoted commands
oskardotglobal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # isIdea: whether to write the current rust toolchain into `.idea/workspace.xml`, defaults to false | ||
| # nixpkgs: the path to a nixpkgs checkout, defaults to a pinned version | ||
| # mkToolchain: a function taking a fenix instance and returning a toolchain, defaults to `fenix: fenix.complete` | ||
| use nix # \ | ||
| # --arg isIdea true \ | ||
| # --arg nixpkgs '<nixpkgs>' \ | ||
| # --arg mkToolchain 'fenix: fenix.beta' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # Contribution Guidelines | ||
|
|
||
| Thank you for contributing to winapps! Before you can contribute, we ask some things of you: | ||
|
|
||
| - Please follow our Code of Conduct, the Contributor Covenant. You can find a copy in this repository or under <https://www.contributor-covenant.org> | ||
| - All Contributors have to sign a Developer Certificate of Origin, agreeing to license their contribution under the AGPLv3. You can find a copy of the DCO below or under <https://developercertificate.org>. | ||
| - Please follow code conventions enforced by `pre-commit`. To keep down CI usage, please run it locally before committing too. | ||
| See <https://pre-commit.com> for installation, then run `pre-commit install` inside the repository you cloned. | ||
|
|
||
| ## Developer Certificate of Origin | ||
|
|
||
| Developer Certificate of Origin | ||
| Version 1.1 | ||
|
|
||
| Copyright (C) 2004, 2006 The Linux Foundation and its contributors. | ||
|
|
||
| Everyone is permitted to copy and distribute verbatim copies of this | ||
| license document, but changing it is not allowed. | ||
|
|
||
|
|
||
| Developer's Certificate of Origin 1.1 | ||
|
|
||
| By making a contribution to this project, I certify that: | ||
|
|
||
| (a) The contribution was created in whole or in part by me and I | ||
| have the right to submit it under the open source license | ||
| indicated in the file; or | ||
|
|
||
| (b) The contribution is based upon previous work that, to the best | ||
| of my knowledge, is covered under an appropriate open source | ||
| license and I have the right under that license to submit that | ||
| work with modifications, whether created in whole or in part | ||
| by me, under the same open source license (unless I am | ||
| permitted to submit under a different license), as indicated | ||
| in the file; or | ||
|
|
||
| (c) The contribution was provided directly to me by some other | ||
| person who certified (a), (b) or (c) and I have not modified | ||
| it. | ||
|
|
||
| (d) I understand and agree that this project and the contribution | ||
| are public and that a record of the contribution (including all | ||
| personal information I submit with it, including my sign-off) is | ||
| maintained indefinitely and may be redistributed consistent with | ||
| this project or the open source license(s) involved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| name: Bug Report | ||
| description: File a bug report. | ||
| labels: ["triage"] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| We cannot fix nor support all bugs caused by FreeRDP, especially on Wayland. | ||
| If you experience visual bugs, please open a discussion instead. | ||
|
|
||
| - type: textarea | ||
| id: what-happened | ||
| attributes: | ||
| label: What happened? | ||
| description: Also tell us, what did you expect to happen? | ||
| placeholder: Tell us what you see! | ||
| value: "A bug happened!" | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: input | ||
| id: freerdp | ||
| attributes: | ||
| label: Your FreeRDP version and where you got it from | ||
| placeholder: "FreeRDP 3.10 (Debian Backports)" | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: input | ||
| id: distro | ||
| attributes: | ||
| label: Your Linux distribution and version | ||
| placeholder: "Debian Trixie" | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: config | ||
| attributes: | ||
| label: Your `winapps.conf` | ||
| description: Please copy and paste your `winapps.conf`. Make sure to not include any sensitive data. This will be automatically formatted into code, so no need for backticks. | ||
| render: shell | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: logs | ||
| attributes: | ||
| label: Logs | ||
| description: Give the output of WinApps, FreeRDP etc. where / if applicable. | ||
| render: shell | ||
|
|
||
| - type: checkboxes | ||
| id: terms | ||
| attributes: | ||
| label: Terms | ||
| options: | ||
| - label: I am running the latest version. | ||
| required: true | ||
| - label: To the best of my knowledge, this is a bug and not a setup nor a FreeRDP problem. | ||
| required: true | ||
| - label: I have checked for duplicate issues. | ||
| required: true | ||
| - label: I agree to follow this project's Code of Conduct. | ||
| required: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| blank_issues_enabled: false | ||
| contact_links: | ||
| - name: Community Support | ||
| url: https://github.com/winapps-org/winapps/discussions | ||
| about: Get help with non-bug issues here. Please use this instead of filing bug reports. |
LDprg marked this conversation as resolved.
Show resolved
Hide resolved
|
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: Format and lint | ||
|
|
||
| on: | ||
| push: | ||
| branches: ["rewrite"] | ||
| pull_request: | ||
| branches: ["rewrite"] | ||
|
|
||
| permissions: | ||
| checks: write | ||
|
|
||
| jobs: | ||
| check: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: dtolnay/rust-toolchain@nightly | ||
| with: | ||
| components: clippy | ||
|
|
||
| - uses: auguwu/clippy-action@1.4.0 | ||
| with: | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| name: Build container image | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ "rewrite" ] | ||
| paths: [ "winapps-image/**" ] | ||
| workflow_dispatch: | ||
| schedule: | ||
| # See https://crontab.guru/monthly | ||
| - cron: 0 0 1 * * | ||
|
|
||
| permissions: | ||
| packages: write | ||
|
|
||
| env: | ||
| IMAGE_REGISTRY: ghcr.io | ||
| IMAGE_NAME: winapps-org/windows | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Extract metadata (tags, labels) for Docker | ||
| id: meta | ||
| uses: docker/metadata-action@v5 | ||
| with: | ||
| images: ${{ env.IMAGE_REGISTRY }}/${{ env.IMAGE_NAME }} | ||
|
|
||
| - name: Build image | ||
| id: build | ||
| uses: redhat-actions/buildah-build@v2 | ||
| with: | ||
| image: ${{ env.IMAGE_NAME }} | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} | ||
| context: winapps-image | ||
| containerfiles: winapps-image/Containerfile | ||
|
|
||
| - name: Push image to GHCR | ||
| uses: redhat-actions/push-to-registry@v2 | ||
| with: | ||
| image: ${{ steps.build.outputs.image }} | ||
| tags: ${{ steps.build.outputs.tags }} | ||
| registry: ${{ env.IMAGE_REGISTRY }} | ||
| username: ${{ github.actor }} | ||
| password: ${{ secrets.GITHUB_TOKEN }} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,12 @@ | ||
| # Generated files | ||
| target/ | ||
|
|
||
| # The library shouldn't decide about the exact versions of | ||
| # its dependencies, but let the downstream crate decide. | ||
| Cargo.lock | ||
LDprg marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| /result | ||
| .DS_Store | ||
|
|
||
| # We don't want to commit IDE configuration files. | ||
| .idea/ | ||
| winapps.iml | ||
| .vscode/ | ||
| .direnv | ||
| .wakatime-project | ||
| .envrc | ||
oskardotglobal marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| unstable_features = true | ||
| imports_granularity = "Crate" |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.