Skip to content

Conversation

@mjauvin
Copy link
Member

@mjauvin mjauvin commented Dec 21, 2024

This is supposed to run once, make it so in all cases.

@mjauvin mjauvin added this to the 1.2.8 milestone Dec 21, 2024
@mjauvin mjauvin requested a review from LukeTowers December 21, 2024 12:44
@mjauvin mjauvin self-assigned this Dec 21, 2024
@LukeTowers
Copy link
Member

@mjauvin is this still needed? Can we have any unit tests added for this?

@mjauvin
Copy link
Member Author

mjauvin commented Feb 26, 2025

It's needed if we want a bindEventOnce() call that is also halting to be removed from the event listener array since the method returns before reaching the call that does this when $halting = false.

@mjauvin
Copy link
Member Author

mjauvin commented Feb 26, 2025

I'll see what I can do for a unit test.

@mjauvin
Copy link
Member Author

mjauvin commented Feb 26, 2025

@LukeTowers was able to add a unit test for this.

I tested commenting out the unset() statement and it does indeed fail the unit test.

@LukeTowers LukeTowers merged commit c9b6357 into develop Feb 26, 2025
10 checks passed
@LukeTowers LukeTowers deleted the bind-event-once branch February 26, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants