Skip to content

Conversation

@sbakhtiarov
Copy link
Contributor

@sbakhtiarov sbakhtiarov commented Dec 8, 2025

TaskWPB-17811 [Web] Add/edit cells tags

https://wearezeta.atlassian.net/browse/WPB-17811

What's new in this PR?

Fixed issues:

  • Top bar elevation removed
  • Tag chip view and text input aligned
  • Invalid tag input field cursor color in dark mode

Other:

  • Refactoring viewmodel state management

@sbakhtiarov sbakhtiarov force-pushed the chore/tags-ui-refactor branch 2 times, most recently from 1201ec6 to cbcedab Compare December 9, 2025 13:17
@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 9, 2025
@sbakhtiarov sbakhtiarov force-pushed the chore/tags-ui-refactor branch from cbcedab to 83b8ff6 Compare December 12, 2025 09:51
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.55%. Comparing base (c14ed40) to head (3e708e5).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...id/feature/cells/ui/tags/AddRemoveTagsViewModel.kt 94.87% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4467   +/-   ##
========================================
  Coverage    48.55%   48.55%           
========================================
  Files          562      562           
  Lines        19438    19407   -31     
  Branches      3244     3236    -8     
========================================
- Hits          9438     9423   -15     
+ Misses        9007     8995   -12     
+ Partials       993      989    -4     
Files with missing lines Coverage Δ
...id/feature/cells/ui/tags/AddRemoveTagsViewModel.kt 96.22% <94.87%> (+3.91%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c14ed40...3e708e5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants