Open
Conversation
Author
sinwoobang
reviewed
Jun 9, 2020
sinwoobang
left a comment
sinwoobang
left a comment
There was a problem hiding this comment.
안녕하세요, 실행 확인했습니다.
코딩 스타일은 과제 범위가 아닌 걸로 알고 있는데 첨언 차원에서 리뷰해드렸습니다.
|
|
||
| if length == 2: | ||
| nomal_mode() | ||
|
|
There was a problem hiding this comment.
if와 elif 사이 간격이 없어야 합니다.
if 0:
pass
elif 1:
pass
Comment on lines
+30
to
+33
|
|
||
|
|
||
|
|
||
| sampleList = random.sample(randList, len(randList)) |
There was a problem hiding this comment.
코드 사이 간격은 한 줄 또는 두 줄이 최대여야합니다. 지금은 4줄이 있네요.
There was a problem hiding this comment.
변수명은 언더스코어(_) 기반 소문자가 되어야합니다. PEP8을 참조해주세요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
과제3