Open
Conversation
Contributor
|
파이썬 파일을 아이디나 닉네임으로 폴더를 만들고 그안에 넣어주세요~ |
sinwoobang
reviewed
Jun 9, 2020
sinwoobang
left a comment
sinwoobang
left a comment
There was a problem hiding this comment.
안녕하세요, 실행 확인했습니다.
코딩 스타일은 과제 범위가 아닌 걸로 알고 있는데 첨언 차원에서 리뷰해드렸습니다.
|
|
||
|
|
||
|
|
||
| def searchTwo(dir,third): |
There was a problem hiding this comment.
- 콤마(,) 뒤에는 한 칸 띄워주는 것이 PEP8 가이드입니다.
dir, third - 함수명은 언더스코어(_) 기반 소문자로 짓는 것이 PEP8 가이드입니다.
search_two
Comment on lines
+22
to
+37
| fullFilename = os.path.join(dir, file) | ||
| if os.path.isdir(fullFilename): | ||
| for ig in third: | ||
| if ig in fullFilename: | ||
| break | ||
| else: | ||
| if fullFilename.endswith(ig): | ||
| searchTwo(fullFilename,third) | ||
|
|
||
| else: | ||
| for ig in third: | ||
| if ig in fullFilename: | ||
| break | ||
| else: | ||
| file_list.append(fullFilename) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/seoyoung-0/seoyoung-0.github.io
https://seoyoung-0.github.io/