Import Version 1.7 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sorry, I don't have the build environments as well. I used the Github CI for that. Sorry, I don't have the time to fix that here. |
|
@the-reverend I merged it here. And a test build is available here. It seems to work fine on Windows / Linux and I have no access to mac so I cannot test that. If you would like to move this forward in any shape or form please let me know what you think. |
Author
|
hey thanks @AndrewSav! sorry it took so long for me to notice your merge. i'll see what i can do on my wife's macbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our conversation, this is the diff for version 1.7 from neilb-csvfix-93804d497be6.zip. I tested the build on WSL. I don't have a build environment set up for Mac or Win64. In order to run the test suite in linux, I had to change the line endings on all the shell scripts, fix the path to bash, and change the line endings to all the test files and data, but I did not commit those adjustments because I didn't have time to make it cross-platform. A few tests are failing, but these also failed in version 1.6.