split libspdm_try_get_capabilities #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmaroneAMD
reviewed
Jan 12, 2026
Owner
wmaroneAMD
left a comment
wmaroneAMD
left a comment
There was a problem hiding this comment.
Github is awful with its "pending review"
| } | ||
| LIBSPDM_ASSERT (message_size >= transport_header_size + | ||
| spdm_context->local_context.capability.transport_tail_size); | ||
| spdm_request = (void *)(message + transport_header_size); |
Owner
There was a problem hiding this comment.
Why were these variables renamed? This causes the diff to be rather large relative to what the goal is.
| size_t spdm_request_size; | ||
|
|
||
| /* -=[Verify State Phase]=- */ | ||
| if (spdm_context->connection_info.connection_state != LIBSPDM_CONNECTION_STATE_AFTER_VERSION) { |
Owner
There was a problem hiding this comment.
Is the user expected to take ownership of this verification, or will this be duplicated in the user-accessible API? I think it should be moved into the send_request function.
| return status; | ||
| } | ||
| LIBSPDM_ASSERT (message_size >= transport_header_size); | ||
| (void)(transport_header_size); |
Owner
There was a problem hiding this comment.
I would discard this variable and reference the source directly.
Signed-off-by: Manjeet Singh <itsmanjeet1998@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.