-
Notifications
You must be signed in to change notification settings - Fork 18
Tcp timestamp negotiation #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielinux
wants to merge
6
commits into
wolfSSL:master
Choose a base branch
from
danielinux:tcp_timestamp_negotiation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0e6db0a
Add missing retransmissions for SYN/SYNACK/FIN segments
danielinux d1d81cf
Fixed RTO calculation according to RFC6298
danielinux 8e2a1af
Update ssthresh calculation on RTO, per RFC5681
danielinux b152a15
Added 1-byte Zero-window probes
danielinux 3c9a73d
Fix TCP TS option negotiation
danielinux 9591b9b
Fix misplaced null-check orderings (cppcheck)
danielinux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description focuses on TCP timestamp negotiation (only sending TS on ACKs when negotiated), but this PR also introduces substantial additional behavior (RFC6298 RTO computation, persist timer/zero-window probes, control-segment RTO, Karn RTT sampling, congestion-control tweaks). Please either update the PR title/description to reflect the broader scope or split the additional transport/RTO/persist changes into separate PRs to keep review and regression risk manageable.