-
Notifications
You must be signed in to change notification settings - Fork 3
task: Make targets reuse JavaScript builds #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,9 +82,9 @@ make build | |
| # - ios/Sources/GutenbergKit/Gutenberg/ | ||
| # - android/Gutenberg/src/main/assets/ | ||
|
|
||
| # By default, dependencies and translations are only installed if their directories don't exist | ||
| # Force refresh of dependencies and translations | ||
| make build REFRESH_DEPS=1 REFRESH_L10N=1 | ||
| # By default, the build is skipped if output directories already exist | ||
| # Force refresh of dependencies, translations, and JS build | ||
| make build REFRESH_DEPS=1 REFRESH_L10N=1 REFRESH_JS_BUILD=1 | ||
|
|
||
| # Clean build artifacts | ||
| make clean # Clean both dist and translations | ||
|
|
@@ -98,10 +98,13 @@ npm run clean:l10n # Clean only translations directory | |
|
|
||
| ```bash | ||
| # Build Swift package | ||
| swift build | ||
| make build-swift-package | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reinstates directives for Claude to prefer the |
||
|
|
||
| # Build Swift package (force refresh of npm deps/translations/build if needed) | ||
| make build-swift-package REFRESH_DEPS=1 REFRESH_L10N=1 REFRESH_JS_BUILD=1 | ||
|
|
||
| # Run Swift tests | ||
| swift test | ||
| make test-swift-package | ||
| ``` | ||
|
|
||
| ### Android Development | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -243,7 +243,7 @@ build_project() { | |
| return | ||
| fi | ||
|
|
||
| make build REFRESH_DEPS=1 REFRESH_L10N=1 STRICT_L10N=1 | ||
| make build REFRESH_DEPS=1 REFRESH_L10N=1 REFRESH_JS_BUILD=1 STRICT_L10N=1 | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure the release script always creates fresh JavaScript builds. |
||
| print_success "Build completed successfully" | ||
| } | ||
|
|
||
|
|
||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This existing documentation was formatted via the projects' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure CI tasks always rebuild the JavaScript to avoid unexpectedly stale builds.