Merge gutenberg strings in the main strings.xml file#11585
Merge gutenberg strings in the main strings.xml file#11585maxme merged 3 commits intorelease/14.5from
Conversation
|
You can test the changes on this Pull Request by downloading the APK here. |
|
There is a lint error coming from one imported string: I'll update the file manually here and open another PR to fix the script. |
|
Please hold on reviewing that one, it seems there are some extra strings in the generated file, that might come from a missing |
0478620 to
878eada
Compare
|
The patch looks better after 878eada Note after a couple of problems here, I opened: |
|
BTW, I guess the next step is to merge |
loremattei
left a comment
There was a problem hiding this comment.
LGTM!
I'll upload it and merge the branch into master as soon as this is merged 👍
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <?xml version='1.0' encoding='utf-8'?> | |||
There was a problem hiding this comment.
So far I've tried to manually revert this change each time. It's annoying but I haven't found a way to fix it yet
There was a problem hiding this comment.
Is this important? Or just annoying because it's different from the default android format for xml files?
Merge gutenberg strings in the main
strings.xmlfile.