feat: add structured monitoring to migration controller#259
feat: add structured monitoring to migration controller#259thomas-waite wants to merge 23 commits intomainfrom
Conversation
thomas-waite
changed the title
thomas-waite
requested review from
Dzejkop,
andy-t-wang,
lukejmann,
paolodamico,
sideround and
tomislavhoman
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c43bcd5365
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b08129fb2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
thomas-waite
changed the title
| crate::info!( | ||
| "migration_run.started total_processors={} timestamp={}", | ||
| self.processors.len(), | ||
| run_start_time.to_rfc3339() |
There was a problem hiding this comment.
hmm the logging layer should automatically add timestamps
2 participants
Add structured monitoring to migration controller, so we can track state of migration
Added thorough structured monitoring to the migration controller so we can build Datadog dashboards to track the overall status of migrations, including the number of failed migrations, which are failing/succeeding, how long each migration takes etc.
Bedrock implements a foreign logger (a pattern used throughout Bedrock) with the
log()trait exported via UniFFI. The higher level calling app attaches the userId identifying information to the logs, so they can be identified in Datadog.Specifically:
log::info/warn/errorcalls with structuredcrate::info/warn/error key=valuelogging for Datadog dashboard compatibility.duration_msto all execution outcomes - failed, successful etc.