feat!: Refactor idkit-core JS package
#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takaros999
changed the title
idkit-core JS package
Takaros999
requested review from
0x1,
Gr1dlock,
Guardiola31337,
SeanROlszewski,
andy-t-wang and
paolodamico
as code owners
andy-t-wang
reviewed
Jan 17, 2026
Collaborator
andy-t-wang
left a comment
andy-t-wang
left a comment
There was a problem hiding this comment.
This looks fine to me generally. I wonder if we need to split the signal out can we just parse it signal?: string | Uint8Array. Do you see a benefit?
| * @returns Hash output | ||
| */ | ||
| export const generateSignal = (signal: IDKitConfig['signal']): HashFunctionOutput => { | ||
| export const generateSignal = (signal: AbiEncodedValue | string | undefined): HashFunctionOutput => { |
Collaborator
There was a problem hiding this comment.
Why is i better to unpack the type. I feel like we should call this the signalHash
Suggested change
| export const generateSignal = (signal: AbiEncodedValue | string | undefined): HashFunctionOutput => { | |
| export const generateSignalHash = (signal: AbiEncodedValue | string | undefined): HashFunctionOutput => { |
| @@ -0,0 +1,183 @@ | |||
| /** | |||
| * IDKit Session | |||
| * Pure functional API for World ID verification - no dependencies | |||
| * const session = await createSession({ | ||
| * app_id: 'app_staging_xxxxx', | ||
| * action: 'my-action', | ||
| * requests: [ |
Collaborator
There was a problem hiding this comment.
We should talk about syntax here too with requests and policies. How to do all, any etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #44, please review that first.
This PR refactors
idkit-core:Confirmed the refactor works by testing the broswer example.
I will follow up with a react a package and a next example