[no_std] should be declared in binary crate root instead of library. .

[krystian-wojtas]

…Otherwise it cannot be used by std projects

When I try to use si7021 master in another project without this patch, I get following build errors:
https://gitlab.com/krystian.wojtas/weather_station/-/jobs/438899063

[krystian-wojtas]

Here is build with patch applied
https://gitlab.com/krystian.wojtas/weather_station/-/jobs/438901509

[krystian-wojtas]

Pipeline in your orginal project failed because my email address was not verified in github. I don't know how to rerun it now.

[lnicola]

You seem to have vendored (included) the code from this crate into your project. That's why you're getting unused code warnings. Is there a reason you're not using it via cargo instead?

To be more clear, your changes would be fine for your own project, but I don't see a reason to apply them here.

[wose]

Hi,

basically what @lnicola said. Are you aware that you can add unreleased crates to your project by telling cargo the git uri? Something like:

[dependencies]
si7021 = { git = "https://github.com/wose/si7021" }

[lnicola]

@wose I'm on my phone so I haven't checked, but would you consider publishing it? There's quite a bit of squatting going on, and I think someone already wrote another SHT1x driver, probably because they weren't aware of this one.

[wose]

@lnicola Yes. I wanted to publish the crate during last week after adding some more documentation, but didn't got around to finish it. It will probably take another few days. I also looked into supporting some similar sensors with this crate. I thought about renaming the crate it to something like si70xx before publishing it to crates.io.

[krystian-wojtas]

I was not aware that git links works as cargo dependecies without pulishing to crates.io. Thanks for that. I will do it this way.

[krystian-wojtas]

@wose I have si7021 as git link as you adviced me.
https://gitlab.com/krystian.wojtas/weather_station/-/tree/dev-si7021-crate-from-git

But I cannot publish new release with git link

% cargo publish
    Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `si7021` does not specify a version
Note: The published dependency will use the version from crates.io,
the `git` specification will be removed from the dependency declaration

[krystian-wojtas]

Ok, it should be easy
rust-lang/cargo#126

[lnicola]

Ah, sorry, I misread your comment. Indeed, you can't publish a crate with git dependencies, not even if you specify the commit (I think).

[krystian-wojtas]

Right, exact commit didn't help. Still same error message

% cargo publish
    Updating crates.io index
error: all dependencies must have a version specified when publishing.
dependency `si7021` does not specify a version
Note: The published dependency will use the version from crates.io,
the `git` specification will be removed from the dependency declaration.

https://gitlab.com/krystian.wojtas/weather_station/-/commit/74eb953f813055ae1d433204f2dce9ff55b9c00c

[krystian-wojtas]

For clarification as temporarily workaround external si7021 source is moved to src/external directory and mentioned in README

It's in master
https://gitlab.com/krystian.wojtas/weather_station

[krystian-wojtas]

I just renamed crate to be more generic
https://crates.io/crates/prometheus_sensors_exporter

And repository
https://gitlab.com/krystian.wojtas/prometheus_sensors_exporter