Add --skip_authors and --skip_terms as additional flags by kiranpotphode · Pull Request #115 · wp-cli/export-command

kiranpotphode · 2024-07-18T13:24:46Z

This PR introduces --skip_authors and --skip_terms flags for wp export command.

Fixes: #72

codecov · 2025-03-12T09:11:42Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copilot

Pull Request Overview

This PR adds functionality to skip authors and terms (categories, tags, custom taxonomy terms, and nav menu terms) from WordPress export files. The implementation follows the existing pattern used by the --skip_comments flag.

Key Changes:

Added --skip_authors and --skip_terms command-line flags
Implemented exclusion mechanism in WP_Export_Split_Files_Writer to filter out specified sections
Modified before_posts() method signature to accept available sections parameter

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
src/Export_Command.php	Added CLI parameters and validation methods for `--skip_authors` and `--skip_terms` flags, populating the `$exclude` array based on user input
src/WP_Export_Split_Files_Writer.php	Implemented section exclusion logic and updated `before_posts()` call to pass filtered sections
features/export.feature	Added test scenarios for the new skip flags

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-02T14:54:31Z

src/WP_Export_Split_Files_Writer.php

+		if ( ! empty( $writer_args['exclude'] ) ) {
+			foreach ( $writer_args['exclude'] as $exclude ) {
+				$key = array_search( $exclude, $this->available_sections, true );
+				if ( false !== $key ) {
+					unset( $this->available_sections[ $key ] );
+				}
+			}
+		}


The exclusion logic removes sections from $this->available_sections after it has already been used to calculate $this->subsequent_sections (line 45). This means excluded sections will still be present in subsequent files when using --include_once. The exclusion logic should be moved before line 44 to ensure excluded sections are properly removed from both $this->available_sections and $this->subsequent_sections.

@copilot open a new pull request to apply changes based on this feedback

src/Export_Command.php

features/export.feature

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

swissspidy · 2026-02-20T12:53:53Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces --skip_authors and --skip_terms flags to the wp export command, allowing for more granular control over exported content. The implementation is solid and includes corresponding tests. I've provided a few suggestions to improve code maintainability by reducing duplication and using more idiomatic PHP, which should make the code cleaner and easier to manage in the future.

gemini-code-assist · 2026-02-20T12:55:43Z

src/Export_Command.php

+		// Re-calculate exclusions after validation to ensure consistency.
+		$this->exclude = [];
+		if ( $this->export_args['skip_authors'] ) {
+			$this->exclude[] = 'authors';
+		}
+		if ( $this->export_args['skip_terms'] ) {
+			$this->exclude = array_merge( $this->exclude, array( 'categories', 'tags', 'nav_menu_terms', 'custom_taxonomies_terms' ) );
+		}


The comment on line 193 is a bit misleading since the exclusion list is being calculated for the first time here, not re-calculated. Additionally, the array on line 199 uses legacy syntax and makes the line quite long. For better readability and adherence to modern PHP standards, I suggest updating the comment and using short array syntax, breaking the line for clarity.

// Calculate exclusions based on flags. $this->exclude = []; if ( $this->export_args['skip_authors'] ) { $this->exclude[] = 'authors'; } if ( $this->export_args['skip_terms'] ) { $this->exclude = array_merge( $this->exclude, [ 'categories', 'tags', 'nav_menu_terms', 'custom_taxonomies_terms', ] ); }

gemini-code-assist · 2026-02-20T12:55:43Z

src/Export_Command.php

+	/**
+	 * @param string|null $skip
+	 *
+	 * @phpstan-ignore method.unused
+	 */
+	private function check_skip_authors( $skip ) {
+		if ( null === $skip ) {
+			return true;
+		}
+
+		if ( 0 !== (int) $skip && 1 !== (int) $skip ) {
+			WP_CLI::warning( 'skip_authors needs to be 0 (no) or 1 (yes).' );
+			return false;
+		}
+		$this->export_args['skip_authors'] = $skip;
+		return true;
+	}
+
+	/**
+	 * @param string|null $skip
+	 *
+	 * @phpstan-ignore method.unused
+	 */
+	private function check_skip_terms( $skip ) {
+		if ( null === $skip ) {
+			return true;
+		}
+
+		if ( 0 !== (int) $skip && 1 !== (int) $skip ) {
+			WP_CLI::warning( 'skip_terms needs to be 0 (no) or 1 (yes).' );
+			return false;
+		}
+		$this->export_args['skip_terms'] = $skip;
+		return true;
+	}


The functions check_skip_authors and check_skip_terms contain nearly identical logic, which is also duplicated from the existing check_skip_comments function. To improve maintainability and reduce code duplication (following the DRY principle), I recommend extracting this logic into a single private helper method. This will make the code cleaner and easier to update in the future if the validation logic for these flags changes.

/** * @param string $flag_name * @param string|null $skip * * @return bool */ private function check_skip_flag( $flag_name, $skip ) { if ( null === $skip ) { return true; } if ( 0 !== (int) $skip && 1 !== (int) $skip ) { WP_CLI::warning( "{$flag_name} needs to be 0 (no) or 1 (yes)." ); return false; } $this->export_args[ $flag_name ] = $skip; return true; } /** * @param string|null $skip * * @phpstan-ignore method.unused */ private function check_skip_authors( $skip ) { return $this->check_skip_flag( 'skip_authors', $skip ); } /** * @param string|null $skip * * @phpstan-ignore method.unused */ private function check_skip_terms( $skip ) { return $this->check_skip_flag( 'skip_terms', $skip ); }

gemini-code-assist · 2026-02-20T12:55:43Z

src/WP_Export_Split_Files_Writer.php

+		if ( ! empty( $writer_args['exclude'] ) ) {
+			foreach ( $writer_args['exclude'] as $exclude ) {
+				$key = array_search( $exclude, $this->available_sections, true );
+				if ( false !== $key ) {
+					unset( $this->available_sections[ $key ] );
+				}
+			}
+		}


The logic to remove excluded sections from $this->available_sections can be significantly simplified by using the built-in array_diff() function. This approach is more concise, readable, and idiomatic than iterating and unsetting elements manually.

if ( ! empty( $writer_args['exclude'] ) ) { $this->available_sections = array_diff( $this->available_sections, $writer_args['exclude'] ); }

kiranpotphode added 4 commits June 18, 2024 19:14

feature: add capability to skip authors & terms

69ca167

feat: add tests for skip_terms and skip_authors args

d8b81f6

chore: optimize code

a08d2e8

chore: add empty array check

e0fd98c

kiranpotphode marked this pull request as ready for review July 18, 2024 13:57

kiranpotphode requested a review from a team as a code owner July 18, 2024 13:57

kiranpotphode and others added 2 commits August 20, 2024 09:50

Merge remote-tracking branch 'origin/main' into 72-lite-export

84aea85

Merge remote-tracking branch 'origin/main' into 72-lite-export

3775bc5

swissspidy requested a review from Copilot November 2, 2025 14:52

Copilot AI reviewed Nov 2, 2025

View reviewed changes

swissspidy added the command:export label Dec 12, 2025

swissspidy and others added 4 commits January 20, 2026 12:29

Update features/export.feature

2186d5a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/Export_Command.php

52df479

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into 72-lite-export

2147bda

Merge branch 'main' into 72-lite-export

ce87eab

gemini-code-assist bot reviewed Feb 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add --skip_authors and --skip_terms as additional flags#115

Add --skip_authors and --skip_terms as additional flags#115
kiranpotphode wants to merge 10 commits intowp-cli:mainfrom
kiranpotphode:72-lite-export

kiranpotphode commented Jul 18, 2024

Uh oh!

codecov bot commented Mar 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 2, 2025

Uh oh!

swissspidy Feb 4, 2026

Uh oh!

Uh oh!

Uh oh!

swissspidy commented Feb 20, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Feb 20, 2026

Uh oh!

gemini-code-assist bot Feb 20, 2026

Uh oh!

gemini-code-assist bot Feb 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kiranpotphode commented Jul 18, 2024

Uh oh!

codecov bot commented Mar 12, 2025

Welcome to Codecov 🎉

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

swissspidy Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

swissspidy commented Feb 20, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants