Skip to content

Upgrade bouncy castle version#485

Open
msm1992 wants to merge 1 commit intowso2:masterfrom
msm1992:master
Open

Upgrade bouncy castle version#485
msm1992 wants to merge 1 commit intowso2:masterfrom
msm1992:master

Conversation

@msm1992
Copy link
Contributor

@msm1992 msm1992 commented Feb 5, 2026

Purpose

Upgrades bouncy castle version

  • bcpkix-jdk15on -> bcpkix-jdk18on
  • bcprov-jdk15on -> bcprov-jdk18on

Summary by CodeRabbit

  • Chores

    • Updated cryptographic security libraries to Java 18-compatible versions for improved system compatibility.
  • Bug Fixes

    • Enhanced certificate validation handling during OCSP verification operations.

@msm1992 msm1992 requested a review from PasanT9 February 5, 2026 08:11
Copy link

@wso2-engineering wso2-engineering bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Agent Log Improvement Checklist

⚠️ Warning: AI-Generated Review Comments

  • The log-related comments and suggestions in this review were generated by an AI tool to assist with identifying potential improvements. Purpose of reviewing the code for log improvements is to improve the troubleshooting capabilities of our products.
  • Please make sure to manually review and validate all suggestions before applying any changes. Not every code suggestion would make sense or add value to our purpose. Therefore, you have the freedom to decide which of the suggestions are helpful.

✅ Before merging this pull request:

  • Review all AI-generated comments for accuracy and relevance.
  • Complete and verify the table below. We need your feedback to measure the accuracy of these suggestions and the value they add. If you are rejecting a certain code suggestion, please mention the reason briefly in the suggestion for us to capture it.
Comment Accepted (Y/N) Reason
#### Log Improvement Suggestion No: 1 N

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Walkthrough

This update upgrades BouncyCastle cryptographic libraries from Java 15 to Java 18+ variants (bcprov-jdk15on/bcpkix-jdk15on to bcprov-jdk18on/bcpkix-jdk18on) across the project, with version 1.83 alignment and an ASN.1 type correction in OCSP certificate validation.

Changes

Cohort / File(s) Summary
BouncyCastle Dependency Upgrade
pom.xml, components/org.wso2.transport.http.netty/pom.xml
Updated bcprov and bcpkix artifacts from jdk15on to jdk18on variants. Parent pom version properties updated to 1.83, with artifact IDs and version property names adjusted accordingly.
OCSP Certificate Validation
components/org.wso2.transport.http.netty/src/main/java/org/wso2/transport/http/netty/contractimpl/common/certificatevalidation/ocsp/OCSPVerifier.java
Replaced DERIA5String with ASN1IA5String import and usage for parsing Authority Information Access (AIA) data when extracting OCSP URLs from certificates.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 From fifteen's path to eighteen's way,
BouncyCastle leaps in cryptographic play,
ASN.1 strings sing a newer tune,
Safer OCSP checks beneath the moon! 🌙✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description only provides a minimal purpose section and omits required sections including Goals, Approach, User stories, Release notes, Documentation, Testing, Security checks, and other critical information. Complete the pull request description by filling out missing sections: Goals explaining why this upgrade is needed, Approach detailing the implementation, test coverage information, security verification, and other required template sections.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: upgrading the Bouncy Castle library version across multiple configuration files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@msm1992 msm1992 requested a review from tharindu1st February 6, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant