Skip to content

Conversation

@krystian-panek-vmltech
Copy link
Collaborator

fixes #281

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ensures that health-check executions of the code executor do not emit notifications, preventing repeated Slack messages when the console executable is configured for notifications (fixing #281).

Changes:

  • Introduced a notifications boolean flag in ExecutionContext, defaulting to true, with corresponding getter/setter.
  • Updated Executor.handleNotifications to respect the per-execution notifications flag before sending any notifications.
  • Updated HealthChecker.checkCodeExecutor to disable both history and notifications for the health-check execution context.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
core/src/main/java/dev/vml/es/acm/core/code/ExecutionContext.java Adds a per-execution notifications flag (default true) with accessors, parallel to existing history/debug flags.
core/src/main/java/dev/vml/es/acm/core/code/Executor.java Extends the notification guard to skip sending notifications when execution.getContext().isNotifications() is false.
core/src/main/java/dev/vml/es/acm/core/instance/HealthChecker.java Disables notifications on the health-check ExecutionContext so health-check runs of the console script do not trigger Slack messages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@krystian-panek-vmltech krystian-panek-vmltech merged commit c0c9dfc into main Jan 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repeated notifications when the "console" is configured as a notificationExecutableId

2 participants