-
Notifications
You must be signed in to change notification settings - Fork 9
Hardened wrapper scripts #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR hardens wrapper scripts for the AEM Compose project by adding comprehensive error handling, retry logic, and validation. The changes also include a migration from Makefile to Taskfile for build automation and the addition of the Maven wrapper (mvnw) with Java vendoring support.
Changes:
- Enhanced shell wrapper scripts (taskw, aemw) with command validation, download retry logic with timeouts, and archive integrity checks
- Replaced Makefile with Taskfile-based build system split into CLI and AEM-specific task files
- Added Maven wrapper (mvnw) with automatic Java preparation and vendoring
- Added default environment configuration files and AEM instance configuration
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/project/common/taskw | Enhanced with command checks, retry logic, timeout handling, and archive validation |
| pkg/project/common/aemw | Enhanced with command checks, retry logic, timeout handling, and archive validation |
| mvnw | New Maven wrapper with Java vendoring and preparation logic |
| aemw | Simple wrapper script to invoke AEM CLI |
| local.env | Default environment variables for AEM instances |
| aem/default/etc/aem.yml | Comprehensive AEM instance configuration |
| Taskfile.yml | Main task configuration with environment variables and includes |
| Taskfile.cli.yml | CLI-related build tasks (test, build, release, etc.) |
| Taskfile.aem.yml | AEM-specific operational tasks (setup, provision, monitoring) |
| Makefile | Removed and replaced with Taskfile system |
| .mvn/wrapper/* | Maven wrapper support files |
| .gitignore | Updated to ignore AEM-specific directories and environment files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.