Skip to content

Conversation

@krystian-panek-vmltech
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens wrapper scripts for the AEM Compose project by adding comprehensive error handling, retry logic, and validation. The changes also include a migration from Makefile to Taskfile for build automation and the addition of the Maven wrapper (mvnw) with Java vendoring support.

Changes:

  • Enhanced shell wrapper scripts (taskw, aemw) with command validation, download retry logic with timeouts, and archive integrity checks
  • Replaced Makefile with Taskfile-based build system split into CLI and AEM-specific task files
  • Added Maven wrapper (mvnw) with automatic Java preparation and vendoring
  • Added default environment configuration files and AEM instance configuration

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
pkg/project/common/taskw Enhanced with command checks, retry logic, timeout handling, and archive validation
pkg/project/common/aemw Enhanced with command checks, retry logic, timeout handling, and archive validation
mvnw New Maven wrapper with Java vendoring and preparation logic
aemw Simple wrapper script to invoke AEM CLI
local.env Default environment variables for AEM instances
aem/default/etc/aem.yml Comprehensive AEM instance configuration
Taskfile.yml Main task configuration with environment variables and includes
Taskfile.cli.yml CLI-related build tasks (test, build, release, etc.)
Taskfile.aem.yml AEM-specific operational tasks (setup, provision, monitoring)
Makefile Removed and replaced with Taskfile system
.mvn/wrapper/* Maven wrapper support files
.gitignore Updated to ignore AEM-specific directories and environment files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@krystian-panek-vmltech krystian-panek-vmltech merged commit 4b74a88 into main Jan 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants