-
Notifications
You must be signed in to change notification settings - Fork 195
Build variants #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build variants #39
Conversation
The google build variant contains the original sources which seems to needs modifications for f-droid. The f-droid variant contains nothing yet.
I would also like to have the app on F-Droid. However, my fork is neither on a technical nor on a legal perspective compatible with that PR. Would you be willing to prepare a new PR? I currently lack the time for major changes, so F-Droid is really far down on the roadmap. |
I currently don't have much time either. When I have some time I'll prepare the PR, but I am not promising anything. |
|
I actually think it would be much easier to place this on a "pure oss" branch with firebase integration removed - which could cut down massively on the code duplication in this PR. Also, I already replaced Firebase Notifications with a GitHub API call, but we would need to make the update checks opt-in by default to comply with F-Droid policy. Also, since F-Droid does not support build secrets we can't work around hostile providers (like Yandex) with our own OAuth secrets - so the F-Droid would definitely be a "lite" version. |
|
Update: I've added a oss branch with firebase/gms removed. This should be ready for RFP now. Edit: RFP is in progress. |
|
I'm going to close this now since the changes proposed here have been included and an RFP is in progress. |
refer to patrykcoding/rcloneExplorer#218