Conversation
Omar-V2
approved these changes
Jan 21, 2026
a5876a3 to
179ad67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instrument File Methods
Checklist
Description
We add instrumentation for the
uploadanddeletemethods for the files SDK.For
upload, the emitted span looks like:For
delete, the emitted span will look like:I wasn't able to find a popular telemetry standard for files, so I elected for this structure. I didn't instrument read-only methods because it didn't seem super reasonable to me, but let me know your thoughts.
I also didn't instrument
batch_uploadsince it's just concurrent executions ofuploadwhich would each receive their own instrumentation.Related Issue
N/A
Type of Change
Instrumentation for Files methods in SDK
Additional Notes
N/A