Scroll selected container instead of the document.body#154
Open
mikocot wants to merge 27 commits intoxbsoftware:masterfrom
Open
Scroll selected container instead of the document.body#154mikocot wants to merge 27 commits intoxbsoftware:masterfrom
mikocot wants to merge 27 commits intoxbsoftware:masterfrom
Conversation
preventEvents parameter
fork improvements listed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In web applications with fixed layout, e.g. fixed side panels, footer, often the body itself does not scroll and all the content is located within one of the containers.
With this change one can specify the container to be scrolled when initializing the 'tour'.
If nothing specified, the default setting (document.body) is used.
Both scrolling to element and scrolling on page resize is supported.