Open
Conversation
ismaell
pushed a commit
to ismaell/xinetd
that referenced
this pull request
Sep 12, 2022
Make sure we use the pkg-config flags when testing for headers, and update the variable names in the Makefile after the rewrite. Fixes xinetd-org#27.
ismaell
added a commit
to ismaell/xinetd
that referenced
this pull request
Sep 12, 2022
Fixes: 4ada39f ("build: fix tirpc usage xinetd-org#27") Ref: openSUSE#40 Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
ismaell
added a commit
to ismaell/xinetd
that referenced
this pull request
Sep 12, 2022
The fourth argument of AC_CHECK_HEADERS (used to indicate the set of includes), is mandantory for autoconf 2.69 and earlier to force modern behavior of the macro. The semantics of the macro changed from using a preprocessor-only check to a compiler check, and the fourth argument determines the use of: classic behavior (for compatibility), a transitional check of both and warnings (returning retro-compatible but potentially inconsistent results), or the use of the modern compiler-based test only. Specifying this argument also suppresses a warning about the topic. Fixes: 4ada39f ("build: fix tirpc usage xinetd-org#27") Ref: openSUSE#40 Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
ismaell
added a commit
to ismaell/xinetd
that referenced
this pull request
Sep 12, 2022
The fourth argument of AC_CHECK_HEADERS (used to indicate the set of includes), is mandatory for autoconf 2.69 and earlier to force modern behavior of the macro. The semantics of the macro changed from using a preprocessor-only check to a compiler check, and the fourth argument determines the use of: classic behavior (for compatibility), a transitional check of both and warnings (returning retro-compatible but potentially inconsistent results), or the use of the modern compiler-based test only. Specifying this argument also suppresses a warning about the topic. Fixes: 4ada39f ("build: fix tirpc usage xinetd-org#27") Ref: openSUSE#40 Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
ismaell
added a commit
to ismaell/xinetd
that referenced
this pull request
Sep 13, 2022
The fourth argument of AC_CHECK_HEADERS (used to indicate the set of includes), is mandatory for autoconf 2.69 and earlier to force modern behavior of the macro. The semantics of the macro changed from using a preprocessor-only check to a compiler check, and the fourth argument determines the use of: classic behavior (for compatibility), a transitional check of both and warnings (returning retro-compatible but potentially inconsistent results), or the use of the modern compiler-based test only. Specifying this argument also suppresses a warning about the topic. Fixes: 4ada39f ("build: fix tirpc usage xinetd-org#27") Ref: openSUSE#40 Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
ismaell
added a commit
to ismaell/xinetd
that referenced
this pull request
Sep 23, 2022
The fourth argument of AC_CHECK_HEADERS (used to indicate the set of includes), is mandatory for autoconf 2.69 and earlier to force modern behavior of the macro. The semantics of the macro changed from using a preprocessor-only check to a compiler check, and the fourth argument determines the use of: classic behavior (for compatibility), a transitional check of both and warnings (returning retro-compatible but potentially inconsistent results), or the use of the modern compiler-based test only. Specifying this argument also suppresses a warning about the topic. Fixes: 4ada39f ("build: fix tirpc usage xinetd-org#27") Ref: openSUSE#40 Signed-off-by: Ismael Luceno <ismael@iodev.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current xinetd hardcoded the output to '/dev/tty' when running in debug mode. May I suggest allowing using '-d' with '-syslog' flags together to write logs into syslog so that can be monitored by jounald(of systemd) and running in daemon mode?