Split tensor arena into persistent and non-persistent arenas#164
Open
andresovela wants to merge 5 commits intoxmos:developfrom
Open
Split tensor arena into persistent and non-persistent arenas#164andresovela wants to merge 5 commits intoxmos:developfrom
andresovela wants to merge 5 commits intoxmos:developfrom
Conversation
Contributor
Author
|
Note that if this gets merged we would need to update the app_flash_two_models_one_arena example |
Contributor
Author
|
I was able to test this feature. See this comment for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix xmos/ai_tools#908
I renamed the
SHARED_TENSOR_ARENAdefinition toEXTERN_TENSOR_ARENA, and I added a newSPLIT_PERSISTENT_TENSOR_ARENAdefinition.This PR adds the following when
SPLIT_PERSISTENT_TENSOR_ARENAis defined:extern uint8_t persistent_tensor_arena[];declarationI had initially renamed
tensor_arenatonon_persistent_tensor_arena, but I found that I had to generate the hugetflTensors[]array twice just because of the new name, so I decided against it. The code would have looked like this otherwise:I haven't been able to test if this would work or not, I just wrote the code for now.