Update stale register name comments in filter_fir_s32.S#210
Closed
Copilot wants to merge 1 commit intovx4b_filter_asmfrom
Closed
Update stale register name comments in filter_fir_s32.S#210Copilot wants to merge 1 commit intovx4b_filter_asmfrom
Copilot wants to merge 1 commit intovx4b_filter_asmfrom
Conversation
Copilot
AI
changed the title
[WIP] Clean up lib_xcore_math filter code and reduce stack usage
Update stale register name comments in filter_fir_s32.S
Jan 30, 2026
Contributor
|
this is pointless! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments in
filter_fir_s32.Sstill reference old architectural register names (x18, x19) after the codebase transitioned to ABI names (s2, s3).Changes:
The code itself is correct—only documentation is stale:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.