feat: upgrade node to v9

.golangci.yml

@@ -1,59 +1,63 @@
 run:
-    tests: true
-    timeout: 5m
-    concurrency: 4
+  tests: true
+  timeout: 5m
+  concurrency: 4
 
 linters:
-    enable:
-        - dogsled
-        - dupl
-        - errcheck
-        - goconst
-        - gocritic
-        - gofumpt
-        - revive
-        - gosec
-        - gosimple
-        - govet
-        - ineffassign
-        - misspell
-        - nakedret
-        - prealloc
-        - exportloopref
-        - staticcheck
-        - stylecheck
-        - typecheck
-        - unconvert
-        - unparam
-        - unused
-        - nolintlint
-        - asciicheck
-        - exportloopref
-        - gofumpt
-        - gomodguard
+  enable:
+    - dogsled
+    - dupl
+    - errcheck
+    - goconst
+    - gocritic
+    - gofumpt
+    - revive
+    - gosec
+    - gosimple
+    - govet
+    - ineffassign
+    - misspell
+    - nakedret
+    - prealloc
+    - exportloopref
+    - staticcheck
+    - stylecheck
+    - typecheck
+    - unconvert
+    - unparam
+    - unused
+    - nolintlint
+    - asciicheck
+    - exportloopref
+    - gofumpt
+    - gomodguard
 
 linters-settings:
-    dogsled:
-        max-blank-identifiers: 3
-    golint:
-        min-confidence: 0
-    maligned:
-        suggest-new: true
-    misspell:
-        locale: US
-    nolintlint:
-        allow-unused: false
-        allow-leading-space: true
-        require-explanation: false
-        require-specific: false
-    gofumpt:
-        lang-version: "1.22"
-    gomodguard:
-        blocked:
-            versions: # List of blocked module version constraints
-                - https://github.com/etcd-io/etcd: # Blocked module with version constraint
-                      version: ">= 3.4.10 || ~3.3.23" # Version constraint, see https://github.com/Masterminds/semver#basic-comparisons
-                      reason: "CVE-2020-15114; CVE-2020-15136; CVE-2020-15115" # Reason why the version constraint exists. (Optional)
-                - https://github.com/dgrijalva/jwt-go: # Blocked module with version constraint
-                      version: ">= 4.0.0-preview1" # Version constraint, see https://github.com/Masterminds/semver#basic-comparisons
-                      reason: "CVE-2020-26160" # Reason why the version constraint exists. (Optional)
+  dogsled:
+    max-blank-identifiers: 3
+  golint:
+    min-confidence: 0
+  maligned:
+    suggest-new: true
+  misspell:
+    locale: US
+  nolintlint:
+    allow-unused: false
+    allow-leading-space: true
+    require-explanation: false
+    require-specific: false
+  staticcheck:
+    checks:
+      - all
+      - '-SA1019'
+  gofumpt:
+    lang-version: "1.22"
+  gomodguard:
+    blocked:
+      versions: # List of blocked module version constraints
+        - https://github.com/etcd-io/etcd: # Blocked module with version constraint
+            version: ">= 3.4.10 || ~3.3.23" # Version constraint, see https://github.com/Masterminds/semver#basic-comparisons
+            reason: "CVE-2020-15114; CVE-2020-15136; CVE-2020-15115" # Reason why the version constraint exists. (Optional)
+        - https://github.com/dgrijalva/jwt-go: # Blocked module with version constraint
+            version: ">= 4.0.0-preview1" # Version constraint, see https://github.com/Masterminds/semver#basic-comparisons
+            reason: "CVE-2020-26160" # Reason why the version constraint exists. (Optional)

Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.22.11 AS base
+FROM golang:1.23.8 AS base
 USER root
 RUN apt update && \
     apt-get install -y \
@@ -20,14 +20,13 @@ RUN make lint
 RUN make test-poa
 # Integration tests
 RUN make test-integration
-RUN make test-upgrade
 # Simulation tests
 RUN make test-sim-benchmark-simulation
 RUN make test-sim-full-app-fast
 
 RUN touch /test.lock
 
-FROM golang:1.22.11 AS release
+FROM golang:1.23.8 AS release
 WORKDIR /
 COPY --from=integration /test.lock /test.lock
 COPY --from=build /app/bin/exrpd /usr/bin/exrpd

Makefile

@@ -140,15 +140,11 @@ mocks:
 	@echo "--> Generating mocks"
 	@./scripts/mockgen.sh
 
-test: test-poa test-integration test-upgrade test-sim-benchmark-simulation test-sim-full-app-fast
-
-test-upgrade:
-	@echo "--> Running upgrade testsuite"
-	@go test -mod=readonly -v ./tests/upgrade
+test: test-poa test-integration test-sim-benchmark-simulation test-sim-full-app-fast
 
 test-integration:
 	@echo "--> Running integration testsuite"
-	@go test -mod=readonly -v ./tests/integration
+	@go test -mod=readonly -tags=test -v ./tests/integration
 
 test-poa:
 	@echo "--> Running POA tests"

app/ante/ante.go

@@ -0,0 +1,54 @@
+package ante
+
+import (
+	errorsmod "cosmossdk.io/errors"
+	"github.com/cosmos/evm/ante"
+
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	errortypes "github.com/cosmos/cosmos-sdk/types/errors"
+	authante "github.com/cosmos/cosmos-sdk/x/auth/ante"
+)
+
+// NewAnteHandler returns an ante handler responsible for attempting to route an
+// Ethereum or SDK transaction to an internal ante handler for performing
+// transaction-level processing (e.g. fee payment, signature verification) before
+// being passed onto it's respective handler.
+func NewAnteHandler(options ante.HandlerOptions) sdk.AnteHandler {
+	return func(
+		ctx sdk.Context, tx sdk.Tx, sim bool,
+	) (newCtx sdk.Context, err error) {
+		var anteHandler sdk.AnteHandler
+
+		txWithExtensions, ok := tx.(authante.HasExtensionOptionsTx)
+		if ok {
+			opts := txWithExtensions.GetExtensionOptions()
+			if len(opts) > 0 {
+				switch typeURL := opts[0].GetTypeUrl(); typeURL {
+				case "/cosmos.evm.vm.v1.ExtensionOptionsEthereumTx":
+					// handle as *evmtypes.MsgEthereumTx
+					anteHandler = newMonoEVMAnteHandler(options)
+				case "/cosmos.evm.types.v1.ExtensionOptionDynamicFeeTx":
+					// cosmos-sdk tx with dynamic fee extension
+					anteHandler = newCosmosAnteHandler(options)
+				default:
+					return ctx, errorsmod.Wrapf(
+						errortypes.ErrUnknownExtensionOptions,
+						"rejecting tx with unsupported extension option: %s", typeURL,
+					)
+				}
+
+				return anteHandler(ctx, tx, sim)
+			}
+		}
+
+		// handle as totally normal Cosmos SDK tx
+		switch tx.(type) {
+		case sdk.Tx:
+			anteHandler = newCosmosAnteHandler(options)
+		default:
+			return ctx, errorsmod.Wrapf(errortypes.ErrUnknownRequest, "invalid transaction type: %T", tx)
+		}
+
+		return anteHandler(ctx, tx, sim)
+	}
+}

app/ante/cosmos_handler.go

@@ -0,0 +1,47 @@
+package ante
+
+import (
+	stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
+	baseevmante "github.com/cosmos/evm/ante"
+	cosmosante "github.com/cosmos/evm/ante/cosmos"
+	evmante "github.com/cosmos/evm/ante/evm"
+	evmtypes "github.com/cosmos/evm/x/vm/types"
+	ibcante "github.com/cosmos/ibc-go/v10/modules/core/ante"
+	poaante "github.com/xrplevm/node/v9/x/poa/ante"
+
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/cosmos/cosmos-sdk/x/auth/ante"
+	sdkvesting "github.com/cosmos/cosmos-sdk/x/auth/vesting/types"
+)
+
+// newCosmosAnteHandler creates the default ante handler for Cosmos transactions
+func newCosmosAnteHandler(options baseevmante.HandlerOptions) sdk.AnteHandler {
+	return sdk.ChainAnteDecorators(
+		cosmosante.NewRejectMessagesDecorator(), // reject MsgEthereumTxs
+		cosmosante.NewAuthzLimiterDecorator( // disable the Msg types that cannot be included on an authz.MsgExec msgs field
+			sdk.MsgTypeURL(&stakingtypes.MsgUndelegate{}),
+			sdk.MsgTypeURL(&stakingtypes.MsgBeginRedelegate{}),
+			sdk.MsgTypeURL(&stakingtypes.MsgCancelUnbondingDelegation{}),
+			sdk.MsgTypeURL(&stakingtypes.MsgDelegate{}),
+			sdk.MsgTypeURL(&sdkvesting.MsgCreateVestingAccount{}),
+			sdk.MsgTypeURL(&evmtypes.MsgEthereumTx{}),
+		),
+		ante.NewSetUpContextDecorator(),
+		ante.NewExtensionOptionsDecorator(options.ExtensionOptionChecker),
+		ante.NewValidateBasicDecorator(),
+		ante.NewTxTimeoutHeightDecorator(),
+		ante.NewValidateMemoDecorator(options.AccountKeeper),
+		cosmosante.NewMinGasPriceDecorator(options.FeeMarketKeeper, options.EvmKeeper),
+		ante.NewConsumeGasForTxSizeDecorator(options.AccountKeeper),
+		ante.NewDeductFeeDecorator(options.AccountKeeper, options.BankKeeper, options.FeegrantKeeper, options.TxFeeChecker),
+		// SetPubKeyDecorator must be called before all signature verification decorators
+		ante.NewSetPubKeyDecorator(options.AccountKeeper),
+		ante.NewValidateSigCountDecorator(options.AccountKeeper),
+		ante.NewSigGasConsumeDecorator(options.AccountKeeper, options.SigGasConsumer),
+		ante.NewSigVerificationDecorator(options.AccountKeeper, options.SignModeHandler),
+		ante.NewIncrementSequenceDecorator(options.AccountKeeper),
+		ibcante.NewRedundantRelayDecorator(options.IBCKeeper),
+		evmante.NewGasWantedDecorator(options.EvmKeeper, options.FeeMarketKeeper),
+		poaante.NewPoaDecorator(),
+	)
+}

app/ante/evm_handler.go

@@ -0,0 +1,23 @@
+package ante
+
+import (
+	"github.com/cosmos/evm/ante"
+	evmante "github.com/cosmos/evm/ante/evm"
+
+	sdk "github.com/cosmos/cosmos-sdk/types"
+)
+
+// newMonoEVMAnteHandler creates the sdk.AnteHandler implementation for the EVM transactions.
+func newMonoEVMAnteHandler(options ante.HandlerOptions) sdk.AnteHandler {
+	decorators := []sdk.AnteDecorator{
+		evmante.NewEVMMonoDecorator(
+			options.AccountKeeper,
+			options.FeeMarketKeeper,
+			options.EvmKeeper,
+			options.MaxTxGasWanted,
+		),
+		ante.NewTxListenerDecorator(options.PendingTxListener),
+	}
+
+	return sdk.ChainAnteDecorators(decorators...)
+}