feat: Add allowSpacesInSuggestions parameter to AutocompleteTrigger#13
Open
biongoo wants to merge 5 commits intoxsahil03x:masterfrom
Open
feat: Add allowSpacesInSuggestions parameter to AutocompleteTrigger#13biongoo wants to merge 5 commits intoxsahil03x:masterfrom
biongoo wants to merge 5 commits intoxsahil03x:masterfrom
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 82.70% 83.24% +0.54%
==========================================
Files 3 3
Lines 185 191 +6
==========================================
+ Hits 153 159 +6
Misses 32 32
☔ View full report in Codecov by Sentry. |
Owner
|
Hey @biongoo nice PR. Can you explain a bit more on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new parameter
allowSpacesInSuggestionsto theAutocompleteTriggerclass. This allows the developer to choose whether the autocomplete suggestions can contain spaces or not.For example, by setting
allowSpacesInSuggestionstotrue, a trigger for '@' after typing '@john ' could even suggest results that include a space, like 'John Doe'.The default behavior (i.e., without specifying
allowSpacesInSuggestionsor setting it tofalse) would be to returnnullas soon as a space is encountered after the trigger character, which means no suggestions are shown.Type of Change