fix for/for_class parameter that don't match between doc and code#124
Open
potatogim wants to merge 1 commit intoxslate:masterfrom
Open
fix for/for_class parameter that don't match between doc and code#124potatogim wants to merge 1 commit intoxslate:masterfrom
potatogim wants to merge 1 commit intoxslate:masterfrom
Conversation
The documentation describing the apply_base_class_role() method of the Mouse::Util::MetaRole package, and other similar methods, explains that it takes "for" parameter. However, they actually take a parameter with the name "for_class", which can be confusing to users and needs to be fixed. So in the apply_base_class_role() method, we also use the _fixup_old_style_args() function to convert the old parameter style to the current one. Signed-off-by: Jihyeon Gim <potatogim@gluesys.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation describing the apply_base_class_role() method of the Mouse::Util::MetaRole package, and other similar methods, explains that it takes "for" parameter.
However, they actually take a parameter with the name "for_class", which can be confusing to users and needs to be fixed.
So in the apply_base_class_role() method, we also use the_fixup_old_style_args() function to convert the old parameter style to the current one.