Skip to content

update cmakelist by adding loop foreach file #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lekhit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update cmakelist by adding loop foreach file #2

lekhit wants to merge 1 commit into from
+7 −92

Conversation

@lekhit
Copy link

@lekhit lekhit commented Nov 9, 2022

Advantage 👍

  1. no need to keep updating the cmakelist file when new files are added
  2. simplified code
    Disadvantage 👎
  3. may be difficult for novice beginner to get understanding

overall 💯

  1. hardly anyone likes making changes for every included file in cmake ( me included :)
  2. so advantages overweight the odds
    please consider merging in if you find it useful

@lekhit
update cmakelist by adding loop foreach file
f0c239d 
simplifying the process of looping valid even when new files are added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lekhit