Add custom sslcontext support in fili#943
Open
Chandrasekar-Rajasekar wants to merge 5 commits intoyahoo:masterfrom
Open
Add custom sslcontext support in fili#943Chandrasekar-Rajasekar wants to merge 5 commits intoyahoo:masterfrom
Chandrasekar-Rajasekar wants to merge 5 commits intoyahoo:masterfrom
Conversation
Contributor
|
definitely need a change to CHANGELOG, and you should probably create an issue to link to in the changelog ticket. Should also add a test to config that this code gets excercised. |
|
|
||
| /** | ||
| * Get a custom configured ssl context. | ||
| * @return SSL context |
Contributor
There was a problem hiding this comment.
Add to comment:
If null, the system default SSL Context will be applied
michael-mclawhorn
approved these changes
Dec 23, 2019
Contributor
michael-mclawhorn
left a comment
There was a problem hiding this comment.
I had one small documentation change. Otherwise feel free to update in preparation for merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User must override getSSLContext method to give their own sslContext. The function should return the object of io.netty.handler.ssl.SslContext.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.