-
Notifications
You must be signed in to change notification settings - Fork 3
Update plugin docs with note of not supporting "standard" validator mode + align node versions to LTS
#745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pe with zod in vite playground.
|
WalkthroughUpdated docs to require ArkType for certain plugins and note validator limitations; standardized tsconfig-paths usage across Vite/Vitest configs; adjusted many package manifests (notably Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Remove arktype as a direct dependency - Add arktype as optional peer for plugins - Update package lock files
…ns, clarify its requirement in the Vite plugin README, and standardize `@types/node` to catalog references.
…n plugin documentation.
"standard" validator mode
📦 Bundle Size Report
✅ All size limits passed! |
…le `arkenv` dependency references.
commit: |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@examples/basic/package.json`:
- Line 14: The zod dependency in package.json is pinned to an exact version
"4.3.5"; update the version string for the "zod" dependency to a semver range
(for example "^4.3.5") so the examples use a compatible future-proof range; edit
the "zod" entry in package.json to replace "4.3.5" with the chosen semver range
and save.
In `@pnpm-workspace.yaml`:
- Line 13: The workspace catalog currently pins '@types/node' at 25.0.9 which
mismatches the examples/basic project's declared Node engine; update one side to
align: either set the workspace catalog entry '@types/node' to a 24.x version
(e.g., `@types/node`@24) to match examples/basic's "engines": { "node": "24" }, or
update examples/basic/package.json to declare "engines": { "node": "25" } so it
matches '@types/node@25.0.9'; pick the approach consistent with your supported
Node target and apply the change to the symbol '@types/node' in the workspace
catalog or the "engines" field in examples/basic/package.json accordingly.
…ples/basic` and regenerate lock files.
…t` and `lib` to `ES2023` across projects.
"standard" validator mode"standard" validator mode + align node versions to LTS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/www/package.json`:
- Line 68: Update the `@types/node` dependency in package.json from "25.x" to
"24.x" to match Node LTS; modify the version string for the "@types/node" entry
and then reinstall/update the lockfile (run npm/Yarn install) so
package-lock.json or yarn.lock reflects the change.
Closes #744
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.