fix: don't import deprecated "wheel" (just to do nothing with it)#823
Open
fix: don't import deprecated "wheel" (just to do nothing with it)#823
Conversation
2 tasks
|
It turns out that this is necessary to work with the |
Author
|
It's not needed (it's not doing anything), so you shouldn't need the minimum. Setuptools (from the first version that supports PEP 517, version 41!) declares it needs wheel in |
Author
|
@nitzmahone setuptools is trying to make a release, but pyyaml is in setuptool's tests and it won't work with the new version of setuptools without this fix. |
38 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
wheelpackage is no longer a dependency of setuptools, so trying to import from it might wipe out the integrated setuptools bdist_wheel command, and will start proceeding a warning or error soon. Since nothing at all is done to it (anymore?), just drop it.