Skip to content

Automated nightly rustfmt (2026-02-01)#8

Open
github-actions[bot] wants to merge 1 commit intomasterfrom
create-pull-request/patch
Open

Automated nightly rustfmt (2026-02-01)#8
github-actions[bot] wants to merge 1 commit intomasterfrom
create-pull-request/patch

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Aug 3, 2025

Automated nightly rustfmt changes by create-pull-request GitHub action

@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-08-03) Automated nightly rustfmt (2025-08-10) Aug 10, 2025
@github-actions github-actions bot force-pushed the create-pull-request/patch branch 2 times, most recently from b45d416 to 23a6272 Compare August 17, 2025 01:11
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-08-10) Automated nightly rustfmt (2025-08-17) Aug 17, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-08-17) Automated nightly rustfmt (2025-08-24) Aug 24, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-08-24) Automated nightly rustfmt (2025-08-31) Aug 31, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-08-31) Automated nightly rustfmt (2025-09-07) Sep 7, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-09-07) Automated nightly rustfmt (2025-09-14) Sep 14, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-09-14) Automated nightly rustfmt (2025-09-21) Sep 21, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-09-21) Automated nightly rustfmt (2025-09-28) Sep 28, 2025
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 23a6272 to 896c67e Compare October 5, 2025 01:04
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-09-28) Automated nightly rustfmt (2025-10-05) Oct 5, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-10-05) Automated nightly rustfmt (2025-10-12) Oct 12, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-10-12) Automated nightly rustfmt (2025-10-19) Oct 19, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-10-19) Automated nightly rustfmt (2025-10-26) Oct 26, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-10-26) Automated nightly rustfmt (2025-11-02) Nov 2, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-11-02) Automated nightly rustfmt (2025-11-09) Nov 9, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-11-09) Automated nightly rustfmt (2025-11-16) Nov 16, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-11-16) Automated nightly rustfmt (2025-11-23) Nov 23, 2025
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 896c67e to 7120d15 Compare November 30, 2025 01:11
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-11-23) Automated nightly rustfmt (2025-11-30) Nov 30, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-11-30) Automated nightly rustfmt (2025-12-07) Dec 7, 2025
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 7120d15 to bb53343 Compare December 14, 2025 01:12
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-12-07) Automated nightly rustfmt (2025-12-14) Dec 14, 2025
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from bb53343 to fcbc878 Compare December 21, 2025 01:12
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-12-14) Automated nightly rustfmt (2025-12-21) Dec 21, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-12-21) Automated nightly rustfmt (2025-12-28) Dec 28, 2025
@github-actions github-actions bot changed the title Automated nightly rustfmt (2025-12-28) Automated nightly rustfmt (2026-01-04) Jan 4, 2026
yancyribbens pushed a commit that referenced this pull request Jan 5, 2026
…prefix

5d4f9cf Fix decoder bug when ending before decoding prefix (Shing Him Ng)

Pull request description:

  Before this fix, calling `ByteVecDecoder.end()` on a decoder that hadn't finished reading in the full prefix would result in a valid result of an empty vec. This should instead result in an error, since the decoder shouldn't be able to decode something with an incomplete prefix.
  
  Found from rust-bitcoin#5315 when i was testing some of the fuzzing:
  ```
  INFO: Running with entropic power schedule (0xFF, 100).
  INFO: Seed: 4008033836
  INFO: Loaded 1 modules   (726 inline 8-bit counters): 726 [0x100aca050, 0x100aca326),
  INFO: Loaded 1 PC tables (726 PCs): 726 [0x100aca328,0x100acd088),
  INFO:       10 files found in /Users/shingng/git/rust-bitcoin/fuzz/corpus/consensus_encoding_decode_byte_vec
  INFO: -max_len is not provided; libFuzzer will not generate inputs larger than 4096 bytes
  
  thread '<unnamed>' (5327178) panicked at fuzz/fuzz_targets/consensus_encoding/decode_byte_vec.rs:21:17:
  decoder should error when insufficient data provided
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
  ==12615== ERROR: libFuzzer: deadly signal
      #0 0x0001013453c4 in __sanitizer_print_stack_trace+0x28 (librustc-nightly_rt.asan.dylib:arm64+0x5d3c4)
      #1 0x000100a518d4 in fuzzer::PrintStackTrace()+0x30 (consensus_encoding_decode_byte_vec:arm64+0x1000158d4)
      #2 0x000100a45db8 in fuzzer::Fuzzer::CrashCallback()+0x54 (consensus_encoding_decode_byte_vec:arm64+0x100009db8)
      #3 0x00019914f740 in _sigtramp+0x34 (libsystem_platform.dylib:arm64+0x3740)
      #4 0x000199145884 in pthread_kill+0x124 (libsystem_pthread.dylib:arm64+0x6884)
      #5 0x00019904a84c in abort+0x78 (libsystem_c.dylib:arm64+0x7984c)
      #6 0x000100aa9e44 in _RNvNtNtNtCsk9AQ7OSayGk_3std3sys3pal4unix14abort_internal+0x8 (consensus_encoding_decode_byte_vec:arm64+0x10006de44)
      #7 0x000100aa9cd0 in _RNvNtCsk9AQ7OSayGk_3std7process5abort+0x8 (consensus_encoding_decode_byte_vec:arm64+0x10006dcd0)
      #8 0x000100aa5528 in _RNCNvCsaBYAWE6hvc2_13libfuzzer_sys10initialize0B3_+0xb8 (consensus_encoding_decode_byte_vec:arm64+0x100069528)
      rust-bitcoin#9 0x000100a9106c in _RNvNtCsk9AQ7OSayGk_3std9panicking15panic_with_hook+0x264 (consensus_encoding_decode_byte_vec:arm64+0x10005506c)
      rust-bitcoin#10 0x000100a85148 in _RNCNvNtCsk9AQ7OSayGk_3std9panicking13panic_handler0B5_+0x6c (consensus_encoding_decode_byte_vec:arm64+0x100049148)
      rust-bitcoin#11 0x000100a7cad4 in _RINvNtNtCsk9AQ7OSayGk_3std3sys9backtrace26___rust_end_short_backtraceNCNvNtB6_9panicking13panic_handler0zEB6_+0x8 (consensus_encoding_decode_byte_vec:arm64+0x100040ad4)
      rust-bitcoin#12 0x000100a8572c in _RNvCseYE12Li5r0M_7___rustc17rust_begin_unwind+0x1c (consensus_encoding_decode_byte_vec:arm64+0x10004972c)
      rust-bitcoin#13 0x000100aaa484 in _RNvNtCsh0x4TIixgmZ_4core9panicking9panic_fmt+0x24 (consensus_encoding_decode_byte_vec:arm64+0x10006e484)
      rust-bitcoin#14 0x000100a3d6ac in _RNvNvCsdWVpjOStM1p_34consensus_encoding_decode_byte_vec1__19___libfuzzer_sys_run decode_byte_vec.rs:45
      rust-bitcoin#15 0x000100a3f52c in rust_fuzzer_test_input lib.rs:276
      rust-bitcoin#16 0x000100a4436c in _RINvNvNtCsk9AQ7OSayGk_3std9panicking12catch_unwind7do_callNCNvCsaBYAWE6hvc2_13libfuzzer_sys15test_input_wrap0lEBY_+0xc4 (consensus_encoding_decode_byte_vec:arm64+0x10000836c)
      rust-bitcoin#17 0x000100a45034 in __rust_try+0x18 (consensus_encoding_decode_byte_vec:arm64+0x100009034)
      rust-bitcoin#18 0x000100a43c6c in LLVMFuzzerTestOneInput+0x16c (consensus_encoding_decode_byte_vec:arm64+0x100007c6c)
      rust-bitcoin#19 0x000100a47670 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long)+0x158 (consensus_encoding_decode_byte_vec:arm64+0x10000b670)
      rust-bitcoin#20 0x000100a488e8 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__1::vector<fuzzer::SizedFile, std::__1::allocator<fuzzer::SizedFile>>&)+0x240 (consensus_encoding_decode_byte_vec:arm64+0x10000c8e8)
      rust-bitcoin#21 0x000100a49058 in fuzzer::Fuzzer::Loop(std::__1::vector<fuzzer::SizedFile, std::__1::allocator<fuzzer::SizedFile>>&)+0x88 (consensus_encoding_decode_byte_vec:arm64+0x10000d058)
      rust-bitcoin#22 0x000100a676b8 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long))+0x1aa4 (consensus_encoding_decode_byte_vec:arm64+0x10002b6b8)
      rust-bitcoin#23 0x000100a74158 in main+0x24 (consensus_encoding_decode_byte_vec:arm64+0x100038158)
      rust-bitcoin#24 0x000198d7dd50  (<unknown module>)
  
  NOTE: libFuzzer has rudimentary signal handlers.
        Combine libFuzzer with AddressSanitizer or similar for better crash reports.
  SUMMARY: libFuzzer: deadly signal
  MS: 0 ; base unit: 0000000000000000000000000000000000000000
  
  
  artifact_prefix='/Users/shingng/git/rust-bitcoin/fuzz/artifacts/consensus_encoding_decode_byte_vec/'; Test unit written to /Users/shingng/git/rust-bitcoin/fuzz/artifacts/consensus_encoding_decode_byte_vec/crash-da39a3ee5e6b4b0d3255bfef95601890afd80709
  Base64:
  
  ────────────────────────────────────────────────────────────────────────────────
  
  Failing input:
  
  fuzz/artifacts/consensus_encoding_decode_byte_vec/crash-da39a3ee5e6b4b0d3255bfef95601890afd80709
  
  Output of `std::fmt::Debug`:
  
  []
  
  Reproduce with:
  
  cargo fuzz run consensus_encoding_decode_byte_vec fuzz/artifacts/consensus_encoding_decode_byte_vec/crash-da39a3ee5e6b4b0d3255bfef95601890afd80709
  
  Minimize test case with:
  
  cargo fuzz tmin consensus_encoding_decode_byte_vec fuzz/artifacts/consensus_encoding_decode_byte_vec/crash-da39a3ee5e6b4b0d3255bfef95601890afd80709
  
  ────────────────────────────────────────────────────────────────────────────────
  
  Error: Fuzz target exited with exit status: 77
  ```


ACKs for top commit:
  apoelstra:
    ACK 5d4f9cf; successfully ran local tests
  tcharding:
    ACK 5d4f9cf


Tree-SHA512: 89298839cfc33b2cf3379ca5ddcbf3edb94b81d5dfae01ca23b034e390f01653a1a147642928313ae02a2136a9a9397f6f66d369abb12786016ac2186638f076
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from fcbc878 to 0c8552c Compare January 11, 2026 01:16
@github-actions github-actions bot changed the title Automated nightly rustfmt (2026-01-04) Automated nightly rustfmt (2026-01-11) Jan 11, 2026
@github-actions github-actions bot changed the title Automated nightly rustfmt (2026-01-11) Automated nightly rustfmt (2026-01-18) Jan 18, 2026
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 0c8552c to 8907d1b Compare January 18, 2026 01:15
yancyribbens pushed a commit that referenced this pull request Jan 23, 2026
…f funding utxos

a5bd502 Fix unreachable error bug during iteration of funding utxos (Shing Him Ng)

Pull request description:

  Found this while working on a psbt fuzz target:
  
  ```
  INFO: Running with entropic power schedule (0xFF, 100).
  INFO: Seed: 3835569058
  INFO: Loaded 1 modules   (61329 inline 8-bit counters): 61329 [0x100a2acf0, 0x100a39c81),
  INFO: Loaded 1 PC tables (61329 PCs): 61329 [0x100a39c88,0x100b29598),
  target/aarch64-apple-darwin/release/bitcoin_arbitrary_psbt: Running 1 inputs 1 time(s) each.
  Running: fuzz/artifacts/bitcoin_arbitrary_psbt/crash-ba0bb9c6187caa78cd865a232ef56ea1a690e25b
  
  thread '<unnamed>' (7096951) panicked at bitcoin/src/psbt/mod.rs:204:18:
  internal error: entered unreachable code
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
  ==48521== ERROR: libFuzzer: deadly signal
      #0 0x0001012893c4 in __sanitizer_print_stack_trace+0x28 (librustc-nightly_rt.asan.dylib:arm64+0x5d3c4)
      #1 0x0001007c8300 in fuzzer::PrintStackTrace()+0x30 (bitcoin_arbitrary_psbt:arm64+0x100354300)
      #2 0x0001007bc7e4 in fuzzer::Fuzzer::CrashCallback()+0x54 (bitcoin_arbitrary_psbt:arm64+0x1003487e4)
      #3 0x00019914f740 in _sigtramp+0x34 (libsystem_platform.dylib:arm64+0x3740)
      #4 0x000199145884 in pthread_kill+0x124 (libsystem_pthread.dylib:arm64+0x6884)
      #5 0x00019904a84c in abort+0x78 (libsystem_c.dylib:arm64+0x7984c)
      #6 0x0001008429c4 in _RNvNtNtNtCsk9AQ7OSayGk_3std3sys3pal4unix14abort_internal+0x8 (bitcoin_arbitrary_psbt:arm64+0x1003ce9c4)
      #7 0x000100842820 in _RNvNtCsk9AQ7OSayGk_3std7process5abort+0x8 (bitcoin_arbitrary_psbt:arm64+0x1003ce820)
      #8 0x00010083d9fc in _RNCNvCsaBYAWE6hvc2_13libfuzzer_sys10initialize0B3_+0xb8 (bitcoin_arbitrary_psbt:arm64+0x1003c99fc)
      rust-bitcoin#9 0x0001008174d4 in _RNvNtCsk9AQ7OSayGk_3std9panicking15panic_with_hook+0x264 (bitcoin_arbitrary_psbt:arm64+0x1003a34d4)
      rust-bitcoin#10 0x00010080b5b0 in _RNCNvNtCsk9AQ7OSayGk_3std9panicking13panic_handler0B5_+0x6c (bitcoin_arbitrary_psbt:arm64+0x1003975b0)
      rust-bitcoin#11 0x000100802f0c in _RINvNtNtCsk9AQ7OSayGk_3std3sys9backtrace26___rust_end_short_backtraceNCNvNtB6_9panicking13panic_handler0zEB6_+0x8 (bitcoin_arbitrary_psbt:arm64+0x10038ef0c)
      rust-bitcoin#12 0x00010080bb94 in _RNvCseYE12Li5r0M_7___rustc17rust_begin_unwind+0x1c (bitcoin_arbitrary_psbt:arm64+0x100397b94)
      rust-bitcoin#13 0x00010084311c in _RNvNtCsh0x4TIixgmZ_4core9panicking9panic_fmt+0x24 (bitcoin_arbitrary_psbt:arm64+0x1003cf11c)
      rust-bitcoin#14 0x0001008430f4 in _RNvNtCsh0x4TIixgmZ_4core9panicking5panic+0x10 (bitcoin_arbitrary_psbt:arm64+0x1003cf0f4)
      rust-bitcoin#15 0x00010056c670 in _RNvMNtCs9rLNVcx1A2L_7bitcoin4psbtNtB2_4Psbt39internal_extract_tx_with_fee_rate_limit+0x4e0 (bitcoin_arbitrary_psbt:arm64+0x1000f8670)
      rust-bitcoin#16 0x00010049ddd8 in _RNvNvCshHXwvrCOqYg_22bitcoin_arbitrary_psbt1__19___libfuzzer_sys_run arbitrary_psbt.rs:41
      rust-bitcoin#17 0x0001004a545c in rust_fuzzer_test_input lib.rs:276
      rust-bitcoin#18 0x0001007bad98 in _RINvNvNtCsk9AQ7OSayGk_3std9panicking12catch_unwind7do_callNCNvCsaBYAWE6hvc2_13libfuzzer_sys15test_input_wrap0lEBY_+0xc4 (bitcoin_arbitrary_psbt:arm64+0x100346d98)
      rust-bitcoin#19 0x0001007bba60 in __rust_try+0x18 (bitcoin_arbitrary_psbt:arm64+0x100347a60)
      rust-bitcoin#20 0x0001007ba698 in LLVMFuzzerTestOneInput+0x16c (bitcoin_arbitrary_psbt:arm64+0x100346698)
      rust-bitcoin#21 0x0001007be09c in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long)+0x158 (bitcoin_arbitrary_psbt:arm64+0x10034a09c)
      rust-bitcoin#22 0x0001007d955c in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long)+0xd8 (bitcoin_arbitrary_psbt:arm64+0x10036555c)
      rust-bitcoin#23 0x0001007de1cc in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long))+0x1b8c (bitcoin_arbitrary_psbt:arm64+0x10036a1cc)
      rust-bitcoin#24 0x0001007eab84 in main+0x24 (bitcoin_arbitrary_psbt:arm64+0x100376b84)
      rust-bitcoin#25 0x000198d7dd50  (<unknown module>)
  
  NOTE: libFuzzer has rudimentary signal handlers.
        Combine libFuzzer with AddressSanitizer or similar for better crash reports.
  SUMMARY: libFuzzer: deadly signal
  ────────────────────────────────────────────────────────────────────────────────
  ```
  
  I wasn't positive on if i should group it with `Error::MissingUtxo` and return `ExtractTxError::MissingInputAmount`


ACKs for top commit:
  tcharding:
    ACK a5bd502
  apoelstra:
    ACK a5bd502; successfully ran local tests


Tree-SHA512: 0fcc7663a5a3458f1eb5a968e200928c5476dfcce9a765437bab5987294373ba8e919d8e606de06ee69acda2100ffb348907173d8c9ce7a4cc62efb5ad108f8b
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 8907d1b to 1e8f8df Compare January 25, 2026 01:17
@github-actions github-actions bot changed the title Automated nightly rustfmt (2026-01-18) Automated nightly rustfmt (2026-01-25) Jan 25, 2026
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 1e8f8df to ae0154a Compare February 1, 2026 01:44
@github-actions github-actions bot changed the title Automated nightly rustfmt (2026-01-25) Automated nightly rustfmt (2026-02-01) Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants