Merged
Conversation
- Add PAYPAL to BankAccountPair.BankName enum - Create PayPalDebitCsvTemplate to parse PayPal transaction history - Add comprehensive tests verifying: * Only completed transactions are processed (pending/denied filtered out) * Amount signs are inverted correctly (deposits negative, expenses positive) * Transaction parsing and mapping works correctly - Add test CSV file: paypal_balance_debit.csv
- Add normalizeAmount() to invert amount signs (deposits negative, expenses positive) - Add validate() to filter out non-completed transactions (pending/denied) - Fixes test failures for sign inversion and pending transaction filtering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for importing PayPal transaction history CSV files.
Changes
Tests
Added comprehensive test suite in
BankAccountCsvFactoryImplTest.PayPalDebitTests:parsesTransactionsCorrectly()- Verifies transaction parsing, amount inversion, and field mappingfiltersOutPendingTransactions()- Ensures only completed transactions are processedinvertsAmountSignsCorrectly()- Validates deposit/expense sign inversion logicTest Data
paypal_balance_debit.csvtest file with sample PayPal transactionsNotes