Skip to content

Conversation

@amyyeung17
Copy link
Contributor

@amyyeung17 amyyeung17 commented Sep 11, 2025

Proposed changes

This PR adds a publish-npm CI workflow with tag verification step, allowing automated publishing using tags.
See yeatmanlab/roar-firekit#186 and additional fix from yeatmanlab/roar-firekit#188.

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Tag verification has been tested and used with roar-firekit. Workflow is copied directly from other games.

Further comments

@amyyeung17 amyyeung17 requested a review from a team as a code owner September 11, 2025 18:17
@richford richford merged commit 5fbfb8a into main Sep 13, 2025
3 checks passed
@richford richford deleted the maint/update-publish-yml branch September 13, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants