-
Notifications
You must be signed in to change notification settings - Fork 391
feat(aggregation-mode): handle processing that have failed in the aggregation process #2210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MarcosNicolau
wants to merge
7
commits into
staging
Choose a base branch
from
feat/missing-processing-proofs
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+74
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuArce
approved these changes
Dec 18, 2025
JuArce
requested changes
Dec 18, 2025
…explanation comment
maximopalopoli
approved these changes
Dec 19, 2025
JuArce
reviewed
Dec 22, 2025
JuArce
reviewed
Dec 22, 2025
| pub program_commitment: Vec<u8>, | ||
| pub merkle_path: Option<Vec<u8>>, | ||
| pub status: TaskStatus, | ||
| pub status_updated_at: Option<DateTime<Utc>>, |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| pub status_updated_at: Option<DateTime<Utc>>, | |
| pub status_updated_at: DateTime<Utc>, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When aggregating proofs, we mark all the proofs to aggregate to
processingso no other proof aggregator aggregates them. The problem is that in the case the proof aggregator fails at any step, the tasks status would stay inprocessingand no other process would take them to aggregate.The presented solution to this is:
pendingagain, so it become available for other aggregators1.fails or the machine was shut down in the middle of the process, then we check the newstatus_updated_atflag in the task. If 12 hours have passed since the update toprocessingthen it is also valid for the aggregator to take.How to test
aggregation_mode/proof_aggregator/src/backend/merkle_tree.rs:http://localhost:8090processingstatus and set the timestamp to a number that is 12 hours in the past from now (you can do that here).Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging