feat(aggregation-mode): support multiple dbs #2214
Open
+610
−190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosNicolau
force-pushed
the
feat/support-multiple-dbs
branch
from
430d4db to
5340365
Compare
| /// Clones share health state (the atomics) and the underlying pools, so all clones observe and influence | ||
| /// the same “preferred node” ordering decisions. | ||
| #[derive(Debug, Clone)] | ||
| pub struct DbOrchestartor { |
Collaborator
There was a problem hiding this comment.
This should be called DbOrchestrator
| // until the delay reaches `max_delay_seconds`, after which it stays at that max. | ||
| // see reference: https://en.wikipedia.org/wiki/Exponential_backoff | ||
| // and here: https://docs.aws.amazon.com/prescriptive-guidance/latest/cloud-design-patterns/retry-backoff.html | ||
| fn next_backoff_delay(&self, current_delay: Duration) -> Duration { |
Collaborator
There was a problem hiding this comment.
Maybe we can move this function to aggregation_mode/db/src/retry.rs, as it's related to the retry functionality.
| Ok(value) => return Ok(value), | ||
| Err(RetryError::Permanent(err)) => return Err(err), | ||
| Err(RetryError::Transient(err)) => { | ||
| if attempts >= self.retry_config.max_delay_seconds { |
Collaborator
There was a problem hiding this comment.
I don't understand this comparison between the number of attempts and the max delay in seconds
| return Err(err); | ||
| } | ||
|
|
||
| tracing::warn!(attempt = attempts, delay_milis = delay.as_millis(), error = ?err, "retrying after backoff"); |
Collaborator
There was a problem hiding this comment.
Suggested change
| tracing::warn!(attempt = attempts, delay_milis = delay.as_millis(), error = ?err, "retrying after backoff"); | |
| tracing::warn!(attempt = attempts, delay_millis = delay.as_millis(), error = ?err, "retrying after backoff"); |
| fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { | ||
| match self { | ||
| RetryError::Transient(e) => write!(f, "{e}"), | ||
| RetryError::Permanent(e) => write!(f, "{e}"), |
Collaborator
There was a problem hiding this comment.
This could be simplified, as both arms have the same behavior.
| #[derive(Clone, Debug)] | ||
| pub struct Db { | ||
| pool: Pool<Postgres>, | ||
| orchestartor: DbOrchestartor, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for multiple databases and retry logic to the following components:
To enable this, a new module/struct called
DbOrchestratorwas introduced. It is responsible for handling retry logic and selecting the appropriate database. The DbOrchestrator exposes two methods:This design reflects the architecture where there is a single primary database for writes, while all other databases are read-only.
How to test
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging