Skip to content

Add context by default #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sebdraven wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Add context by default #922

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
444a99a
Update observable.py
sebdraven Dec 1, 2023
61b83a8
Update observable.py
sebdraven Dec 1, 2023
003080e
Update observable.py
sebdraven Dec 1, 2023
29c835e
Update observable.py
sebdraven Dec 1, 2023
c392daa
Update observable.py
sebdraven Dec 1, 2023
1ef7d1f
Update observable.py
sebdraven Dec 1, 2023
3fd7476
Merge branch 'main' into context
sebdraven Dec 3, 2023
7be754a
Fixes
tomchop Dec 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions core/schemas/observable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,14 @@ def add_text(cls, text: str, tags: list[str] = []) -> "Observable":
return observable

def add_context(
self, source: str, context: dict, skip_compare: set = set()
self, source: str, context: dict | None = None, skip_compare: set | None = None
) -> "Observable":
"""Adds context to an observable."""
if not context:
context = {}
if not skip_compare:
skip_compare = set()

compare_fields = set(context.keys()) - skip_compare - {"source"}
for idx, db_context in enumerate(list(self.context)):
if db_context["source"] != source:
Expand All @@ -110,9 +115,14 @@ def add_context(
return self.save()

def delete_context(
self, source: str, context: dict, skip_compare: set = set()
self, source: str, context: dict | None = None, skip_compare: set | None = None
) -> "Observable":
"""Deletes context from an observable."""
if not context:
context = {}
if not skip_compare:
skip_compare = set()

compare_fields = set(context.keys()) - skip_compare - {"source"}
for idx, db_context in enumerate(list(self.context)):
if db_context["source"] != source:
Expand Down