Fix default goal with newer versions of make #255
Merged
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
=========================================
Coverage 77.22% 77.22%
Complexity 52 52
=========================================
Files 16 16
Lines 180 180
=========================================
Hits 139 139
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes compatibility with newer versions of make by refactoring how the default goal is determined. The change ensures that when make is invoked without arguments, the default "help" goal is correctly selected regardless of make version.
- Refactored the PRIMARY_GOAL initialization logic to check the result of
$(firstword $(MAKECMDGOALS))instead of checkingMAKECMDGOALSdirectly - Maintains backward compatibility with older make versions while supporting newer ones
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of make are not filling
MAKECMDGOALSthe same way as older ones. This fix makes it work with both old and new versions.