Skip to content

Conversation

@rekmixa
Copy link

@rekmixa rekmixa commented Jan 24, 2026

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #135

@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.33%. Comparing base (8d62394) to head (645b609).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
- Coverage     99.33%   99.33%   -0.01%     
  Complexity      162      162              
============================================
  Files            11       11              
  Lines           452      451       -1     
============================================
- Hits            449      448       -1     
  Misses            3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 👍 . Please add a line for CHANGELOG for additional validation added. Thanks.

@rekmixa rekmixa requested a review from samdark January 26, 2026 04:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves mutation testing robustness by adding/adjusting tests and tightening validation in the logging context provider.

Changes:

  • Added validation to reject negative $traceLevel in SystemContextProvider and updated related documentation.
  • Expanded PHPUnit coverage for invalid/unsupported log levels and trace collection expectations.
  • Updated Infection configuration to ignore mutations involving register_shutdown_function.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/ContextProvider/SystemContextProvider.php Adds constructor validation for non-negative trace level; strengthens closure typing in trace filtering.
tests/ContextProvider/SystemContextProviderTest.php New tests covering invalid trace level and presence of expected context keys.
tests/LoggerTest.php Adds tests for invalid log levels; makes trace line assertion resilient to line shifts; strengthens excluded-trace-path assertions.
src/Logger.php Refactors deprecated validateLevel() to delegate to assertLevelIsValid() and adjusts docblock.
infection.json.dist Configures Infection to globally ignore source containing register_shutdown_function.
CHANGELOG.md Documents the trace level validation change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants