Skip to content

Fix for empty extension data #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ltenfield wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for empty extension data #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
976652d
fix: plugin startup problem due to empty persisted data
Feb 12, 2023
40109d7
fix: KeywordsMinus from non array argument
Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ function keywordsToStr(kws, settings){
// and the last one
kws.length && (str += kws[kws.length-1].kwStr);
}else{
if (!Array.isArray(kws)) {
return str
}
str = kws.map(kw=>kw.kwStr).join(settings.delim);
// append deliminator if there are words
str += str ? settings.delim : "";
Expand All @@ -75,6 +78,8 @@ function KeywordsMinus(kwListA, kwListB){
return false;
}
// console.log(kwListA.map(x=>KwListContain(kwListB, x)));
return kwListA.filter(x=>!KwListContain(kwListB, x));

if (Array.isArray(kwListA)) {
return kwListA.filter(x=>!KwListContain(kwListB, x));
}
return [] //empty array
}
3 changes: 3 additions & 0 deletions src/popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ window.addEventListener('load', function() {


function build_keywords_list(inputKws){
if (!Array.isArray(inputKws)) {
return
}
var html = inputKws.map(kw=>`<span class="keywords">${kw.kwStr}</span>`).join("");
$('#kw-list>.keywords').remove();
$(html).appendTo($('#kw-list'));
Expand Down