Skip to content

Replace summarise() with reframe() for dplyr 1.2.0#37

Open
CharcoalF wants to merge 3 commits intomasterfrom
update-summarise-to-reframe
Open

Replace summarise() with reframe() for dplyr 1.2.0#37
CharcoalF wants to merge 3 commits intomasterfrom
update-summarise-to-reframe

Conversation

@CharcoalF
Copy link
Collaborator

As suggested by dplyr author, we need to replace summarise() with reframe() for dplyr 1.2.0. Please review and merge if everything looks good :)

@feng-li
Copy link
Collaborator

feng-li commented Jan 31, 2026

@CharcoalF Thank you for the update. I think further revisions are needed. Could you please carry out the bulk update?

README.md
man/simulate_target.Rd
man/simulate_target.Rd
R/simulate_target.R
vignettes/QuickStart.Rmd

@CharcoalF
Copy link
Collaborator Author

CharcoalF commented Feb 10, 2026

Hi @feng-li, the updates are mainly about to replace the codes below:

# Original
  dplyr::summarise(value = my_features(value), 
          feature = c("entropy", "acf1", "acf2"),
          .groups = "drop")

# Updated
  dplyr::reframe(value = my_features(value), 
        feature = c("entropy", "acf1", "acf2"))

Just after this change, there seems to be some differences in the generated plots. Please let me know if this is the intended outcome, or if any modifications are needed. Thanks

For example, the noise plot now appears more like a linear plot as you may see below:
Screenshot 2026-02-10 at 9 39 19 PM
Screenshot 2026-02-10 at 9 39 26 PM

@feng-li
Copy link
Collaborator

feng-li commented Feb 13, 2026

@CharcoalF Many thanks. I think this was just due to a bad seed. Maybe we could fix the seed just for visualizations.

@CharcoalF
Copy link
Collaborator Author

Hi @feng-li , thank you. Kindly have a cross-check and let me know if any other changes are needed.

Suggest to set.seed(27) As the graph:

  • Moderate fluctuations
  • No extreme outliers
  • Seasonal structure
image image

Other Updates: After running devtools::build_readme() and devtools::document(), update generated files, mainly:

  • .Rbuildignore
  • RoxygenNote in DESCRIPTION
  • man/*.Rd files
  • README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants