Skip to content

Conversation

@Tilix4
Copy link
Contributor

@Tilix4 Tilix4 commented May 22, 2025

Changelog Description

Refactor of hacky render frames/handles management due to AYON's Harmony implementation.

Additional info

Dropped ignoreFrameHandleCheck which was a exception for Harmony.

Made when working on but not required: ynput/ayon-harmony#50

Testing notes:

  1. Regular render publish

@kalisp kalisp requested review from iLLiCiTiT and kalisp May 22, 2025 14:34
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented May 27, 2025

If I get it correctly, this is not mandatory change? Harmony PR ynput/ayon-harmony#50 makes possible that we can remove this, but it would work even without this PR.

If that's the case then we should wait for the harmony PR to be merged and released and bump compatible version of harmony to that released version.

@Tilix4
Copy link
Contributor Author

Tilix4 commented May 27, 2025

If I get it correctly, this is not mandatory change?

In fact no it isn't, you're right. I've tested it and each change completes without the other one being required. You can merge and release without caring about it.

@iLLiCiTiT
Copy link
Member

In fact no it isn't, you're right. I've tested it and each change completes without the other one being required. You can merge and release without caring about it.

So merging this PR won't break older harmony addon versions?

@Tilix4
Copy link
Contributor Author

Tilix4 commented May 27, 2025

So merging this PR won't break older harmony addon versions?

That's what I ended up with my tests, but you cannot rely only on my words, another person has to give it a try.

@iLLiCiTiT
Copy link
Member

@kalisp can you validate this works with latest harmony changes?

@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants