refactor: 💄 Adding cursor-pointer to clickable elements#66
refactor: 💄 Adding cursor-pointer to clickable elements#66hannanel100 wants to merge 1 commit intoyonatanmgr:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Adding cursor-pointer to filter-buttons, OrgIcon, ReposIcon and Project cards.
hannanel100
force-pushed
the
fix-cursor-pointer
branch
from
13d0ab9 to
79b703e
Compare
yonatanmgr
left a comment
yonatanmgr
left a comment
There was a problem hiding this comment.
Hey @hannanel100! Thank you for your time.
I believe cursor-pointer shouldn't be used on arbitrary buttons but only on hyperlinks, in accordance with the W3C UI guidelines (+Apple Human Interface guidelines, Microsoft UX guidelines). The rare cases I do believe it is necessary is on buttons that have some significance over other buttons.
For example, in the repositories list on the right, clicking the project image opens the repository on GitHub, while clicking the project block main body opens the preview on the left. Currently, the user has a clear indication that the image is a hyperlink while the block isn't - and changing the cursor on every button to cursor-pointer removes this clarity.
The current solution we have (abiding the abovementioned guidelines) is having some hover effect on all buttons. A possible improvement is changing the look and feel of those buttons by changing the current colors/hover effects. What do you think?
|
Should we close this PR? |
|
@yonatanmgr I understand what your'e saying regarding the filters. But what I actually don't understand, is why the OrgIcon and ReposIcon aren't just Link components, they are doing navigation, aren't they? |
3 participants
Adding cursor-pointer to filter-buttons, OrgIcon, ReposIcon and Project cards.
#65