Open
Conversation
suranjan
requested changes
Feb 28, 2022
|
|
||
| LOGGER.debug("The offset being loaded in YugabyteDBOffsetContext.. " + offset); | ||
|
|
||
| OpId opid1 = OpId.valueOf((String) offset.get(YugabyteDBOffsetContext.LAST_COMPLETELY_PROCESSED_LSN_KEY)); |
Collaborator
There was a problem hiding this comment.
Use a better variable name
| new OpId(0, 0, null, 0, 0), | ||
| new OpId(0, 0, null, 0, 0), | ||
| new OpId(0, 0, null, 0, 0), | ||
| opid1, |
Collaborator
There was a problem hiding this comment.
What happens when there is no offset loaded?
| for (Pair<String, String> entry : tabletPairList) { | ||
| final String tabletId = entry.getValue(); | ||
| offsetContext.initSourceInfo(tabletId, this.connectorConfig); | ||
| if(offsetContext.lsn(tabletId).equals(new OpId(0,0,null,0,0))){ |
Collaborator
There was a problem hiding this comment.
Check formatting, if we init then lsn will always be new OpId(0,0,null,0,0)).
suranjan
requested changes
Mar 1, 2022
| for (Pair<String, String> entry : tabletPairList) { | ||
| final String tabletId = entry.getValue(); | ||
| offsetContext.initSourceInfo(tabletId, this.connectorConfig); | ||
| offsetContext.getSourceInfo(tabletId).updateLastCommit(offsetContext.lastCompletelyProcessedLsn()); |
Collaborator
There was a problem hiding this comment.
please take care of indentation!
|
|
||
| OpId lastCompletelyProcessedLsn; | ||
| if(offset != null){ | ||
| lastCompletelyProcessedLsn = OpId.valueOf((String) offset.get(YugabyteDBOffsetContext.LAST_COMPLETELY_PROCESSED_LSN_KEY)); |
| sourceInfo.updateLastCommit(lastCommitLsn); | ||
| sourceInfoSchema = sourceInfo.schema(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.