migrate from react-albus to react-step-wizard#32
migrate from react-albus to react-step-wizard#32resolritter wants to merge 1 commit intozaguiini:masterfrom
Conversation
|
Thanks for the PR! In the last few weeks, I'm working on a newer version of the library that accepts not only different wizard components but form libraries as well. This PR could help me achieve that. So far the "v2" is private but as soon as it's public I'll copy the contents of this PR and give you full credit. Please don't stop working on this one as this will be useful! Thanks once again! |
8f542bc to
c18e44e
Compare
|
As I've also made some changes to |
c18e44e to
507a152
Compare
|
opened jcmcneal/react-step-wizard#70 for having the types in I had to look into this repo's exports to figure out I should export React Node types as JSX.Element. @zaguiini do you know why? |
|
I'm not sure, to be honest. Doesn't |
I've tried all weird combinations of importing syntaxes and declarations, but re-exporting the type from the React namespace didn't work. FWIW the MR I put up on |
|
Hey @resolritter, please take a look at #39. Thanks! |
|
@resolritter, any updates? I'd like to incorporate the |
|
I am not currently active on front-end library projects for a while. Not that I dislike them, rather I have some other priorities right now. Regarding #39 's direction, I don't know what'd be the action for me to take there. My gut feeling about reading it is that if you try to wrap everything, you'll only end up reaching the lowest common denominator. That would not lead to the optimal outcome because users wouldn't be able to leverage the underlying library's details. As an example, I made this PR not because I'm looking at the code in https://github.com/zaguiini/formik-wizard/blob/master/src/index.tsx and noticing that the part Finally, in response to your call for action, I don't know what you're expecting of me. |
needs more work to be fully fleshed out, but at least the example doesn't break